Our mixed content layout tests currently just test if some code checks to see if mixed content is allowed; they don't check to see if code correctly blocks the content when it's disallowed.
Note in particular that in this patch, I expose our mixed content preferences in WebPreferencesDefinitions.h.
Created attachment 245448 [details] Improve mixed content layout tests
Comment on attachment 245448 [details] Improve mixed content layout tests Attachment 245448 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6247054317715456 New failing tests: http/tests/security/mixedContent/ssl/insecure-video-in-iframe.html http/tests/security/mixedContent/ssl/insecure-image-in-iframe.html http/tests/security/mixedContent/ssl/insecure-iframe-in-iframe.html http/tests/security/mixedContent/ssl/redirect-http-to-https-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-iframe-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-image-in-iframe-cb.html http/tests/security/mixedContent/ssl/redirect-http-to-https-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-image-in-main-frame.html http/tests/security/mixedContent/ssl/redirect-https-to-http-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-video-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-script-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-css-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-image-in-main-frame-cb.html http/tests/security/mixedContent/ssl/redirect-https-to-http-script-in-iframe.html http/tests/security/mixedContent/ssl/redirect-http-to-https-script-in-iframe.html http/tests/security/mixedContent/ssl/insecure-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-audio-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-plugin-in-iframe.html http/tests/security/mixedContent/ssl/redirect-https-to-http-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-plugin-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-audio-in-iframe.html http/tests/security/mixedContent/ssl/insecure-css-in-main-frame.html http/tests/security/mixedContent/ssl/redirect-http-to-https-script-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-css-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-css-in-iframe.html http/tests/security/mixedContent/ssl/redirect-https-to-http-script-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-script-in-iframe.html
Created attachment 245451 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 245448 [details] Improve mixed content layout tests Attachment 245448 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6271203845079040 New failing tests: http/tests/security/mixedContent/ssl/redirect-https-to-http-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-video-in-iframe.html http/tests/security/mixedContent/ssl/insecure-audio-in-iframe.html http/tests/security/mixedContent/ssl/redirect-https-to-http-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-iframe-in-iframe-cb.html http/tests/security/mixedContent/ssl/redirect-https-to-http-script-in-iframe.html http/tests/security/mixedContent/ssl/redirect-http-to-https-script-in-iframe.html http/tests/security/mixedContent/ssl/insecure-iframe-in-iframe.html http/tests/security/mixedContent/ssl/insecure-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-css-in-iframe.html http/tests/security/mixedContent/ssl/insecure-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-image-in-iframe.html http/tests/security/mixedContent/ssl/insecure-audio-in-main-frame.html http/tests/security/mixedContent/ssl/redirect-http-to-https-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-plugin-in-iframe.html http/tests/security/mixedContent/ssl/redirect-http-to-https-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-script-in-iframe.html http/tests/security/mixedContent/ssl/insecure-video-in-main-frame.html
Created attachment 245453 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
So three problems here: 1) I forgot the patch depends on bug #140621, so I should not have marked this for review at all, and we can expect all tests with an insecure iframe to fail. 2) I forgot about WK1. This is probably very little chance of me being able to fix this speculatively, with neither Windows nor a Mac. I guess I need to find and modify the equivalent in WK1 of WK2's InjectedBundle::overrideBoolPreferenceForTestRunner(). Would be great if someone could provide guidance on this. 3) I see tons of these: [Tue Jan 27 09:49:15 2015] [error] [client 127.0.0.1] File does not exist: /Volumes/Data/EWS/WebKit/LayoutTests/http/tests/security/mixedContent/resources/empty-frame.html, referer: https://127.0.0.1:8443/security/mixedContent/ssl/redirect-https-to-http-script-in-iframe-expected.html The file is definitely present in my patch. My only guess is that some step in the process of getting the patch from bugzilla to the bots loses empty files?
Created attachment 245480 [details] Block mixed content XHR
Comment on attachment 245480 [details] Block mixed content XHR Whoops, the webkit-patch script uploaded this to the wrong bug.
Safe to say I'm never going to return to this after 8 years. The test situation is much better nowadays anyway.