Bug 140937 - [ARM] Typo fix after r176083
Summary: [ARM] Typo fix after r176083
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 108645 136914
  Show dependency tree / graph
 
Reported: 2015-01-27 06:55 PST by Csaba Osztrogonác
Modified: 2015-01-27 09:13 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2015-01-27 06:55 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-01-27 06:55:28 PST 
[ARM] Typo fix after r176083
Comment 1 Csaba Osztrogonác 2015-01-27 06:55:38 PST 
Created attachment 245442 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-01-27 07:00:15 PST 
Comment on attachment 245442 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245442&action=review

> Source/JavaScriptCore/assembler/ARMv7Assembler.h:1158
> -        ASSERT(!(imm.isUInt12() & 1));
> +        ASSERT(!(imm.getUInt12() & 1));

I ran into this assertion during debugging a bug on ARM Linux.

It seems to be a simple typo. isUInt12() returns a logical
value: 0 as false / not 0 as true, But we can't expect if
the non 0 value is an odd number. 

I think the author wanted to expect odd number. In this 
case we should use getUint12() instead of isUInt12().
Comment 3 WebKit Commit Bot 2015-01-27 09:13:16 PST 
Comment on attachment 245442 [details]
Patch

Clearing flags on attachment: 245442

Committed r179187: <http://trac.webkit.org/changeset/179187>
Comment 4 WebKit Commit Bot 2015-01-27 09:13:20 PST 
All reviewed patches have been landed.  Closing bug.