Bug 140863 - Setting HTMLMarqueeElement.trueSpeed doesn't work
Summary: Setting HTMLMarqueeElement.trueSpeed doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 140851
  Show dependency tree / graph
 
Reported: 2015-01-25 00:50 PST by Alexey Proskuryakov
Modified: 2015-01-25 20:05 PST (History)
5 users (show)

See Also:

Attachments
proposed fix (3.74 KB, patch)
2015-01-25 09:53 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-01-25 00:50:36 PST 
HTMLMarqueeElement.trueSpeed is a boolean property, so setting it it to true sets an empty value.

void Element::setBooleanAttribute(const QualifiedName& name, bool value)
{
    if (value)
        setAttribute(name, emptyAtom);
    else
        removeAttribute(name);
}

But then HTMLMarqueeElement::minimumDelay() treats an empty value as false.
Comment 1 Alexey Proskuryakov 2015-01-25 09:53:15 PST 
Created attachment 245308 [details]
proposed fix
Comment 2 WebKit Commit Bot 2015-01-25 20:04:56 PST 
Comment on attachment 245308 [details]
proposed fix

Clearing flags on attachment: 245308

Committed r179102: <http://trac.webkit.org/changeset/179102>
Comment 3 WebKit Commit Bot 2015-01-25 20:05:02 PST 
All reviewed patches have been landed.  Closing bug.