Bug 140851 - fast/html/marquee-scrollamount.html is flaky
Summary: fast/html/marquee-scrollamount.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on: 140863
Blocks:
  Show dependency treegraph
 
Reported: 2015-01-23 22:12 PST by Alexey Proskuryakov
Modified: 2015-01-25 21:01 PST (History)
5 users (show)

See Also:


Attachments
proposed fix (1.53 KB, patch)
2015-01-23 22:14 PST, Alexey Proskuryakov
ddkilzer: review+
ddkilzer: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (558.82 KB, application/zip)
2015-01-23 23:01 PST, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (680.89 KB, application/zip)
2015-01-23 23:07 PST, Build Bot
no flags Details
proposed fix (6.11 KB, patch)
2015-01-25 10:00 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-01-23 22:12:10 PST
fast/html/marquee-scrollamount.html frequently fails on Yosemite Debug WK2.

Looking at the test, it is inherently flaky. Some non-trivial time can pass before the zero delay timer fires, and nothing prevents the marquee from updating its position.
Comment 1 Alexey Proskuryakov 2015-01-23 22:14:39 PST
Created attachment 245277 [details]
proposed fix
Comment 2 Build Bot 2015-01-23 23:01:04 PST
Comment on attachment 245277 [details]
proposed fix

Attachment 245277 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6471229061988352

New failing tests:
fast/html/marquee-scrollamount.html
Comment 3 Build Bot 2015-01-23 23:01:07 PST
Created attachment 245279 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 David Kilzer (:ddkilzer) 2015-01-23 23:04:17 PST
Comment on attachment 245277 [details]
proposed fix

r=me
Comment 5 David Kilzer (:ddkilzer) 2015-01-23 23:06:31 PST
(In reply to comment #4)
> Comment on attachment 245277 [details]
> proposed fix
> 
> r=me

Except it looks like it needs some test results cleanup.
Comment 6 Build Bot 2015-01-23 23:07:08 PST
Comment on attachment 245277 [details]
proposed fix

Attachment 245277 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5230963839729664

New failing tests:
fast/html/marquee-scrollamount.html
Comment 7 Build Bot 2015-01-23 23:07:11 PST
Created attachment 245280 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 8 WebKit Commit Bot 2015-01-23 23:58:31 PST
The commit-queue encountered the following flaky tests while processing attachment 245277 [details]:

The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2015-01-23 23:58:57 PST
The commit-queue encountered the following flaky tests while processing attachment 245277 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 10 Alexey Proskuryakov 2015-01-25 00:50:54 PST
I can fix the test more reliably, but this depends on fixing an actual bug in HTMLMarqueeElement.
Comment 11 Alexey Proskuryakov 2015-01-25 10:00:21 PST
Created attachment 245309 [details]
proposed fix

Not marking for review yet, because this depends on another patch, and EWS wouldn't be testing the right thing.
Comment 12 WebKit Commit Bot 2015-01-25 21:01:26 PST
Comment on attachment 245309 [details]
proposed fix

Clearing flags on attachment: 245309

Committed r179103: <http://trac.webkit.org/changeset/179103>
Comment 13 WebKit Commit Bot 2015-01-25 21:01:32 PST
All reviewed patches have been landed.  Closing bug.