RESOLVED FIXED 140681
[Win] [SVG-> OTF Converter] Flip the switch on
https://bugs.webkit.org/show_bug.cgi?id=140681
Summary [Win] [SVG-> OTF Converter] Flip the switch on
Brent Fulgham
Reported 2015-01-20 09:46:33 PST
[SVG -> OTF Converter] Flip the switch on (Windows)
Attachments
Patch (15.30 KB, patch)
2015-01-20 11:06 PST, Brent Fulgham
no flags
Patch (14.68 KB, patch)
2015-01-20 11:10 PST, Brent Fulgham
mmaxfield: review+
Radar WebKit Bug Importer
Comment 1 2015-01-20 11:01:02 PST
Brent Fulgham
Comment 2 2015-01-20 11:06:22 PST
Brent Fulgham
Comment 3 2015-01-20 11:10:15 PST
Brent Fulgham
Comment 4 2015-01-20 11:11:10 PST
Comment on attachment 245000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245000&action=review > Source/WebCore/svg/SVGToOTFFontConversion.cpp:791 > + const unsigned featureCount = 5; MSVC doesn't allow you to use a variable as the argument to an array declaration.
Brent Fulgham
Comment 5 2015-01-20 11:19:18 PST
It looks like: (1) We still have differences in SVG after turning this on. (2) FontCustomPlatformData::fontPlatformData is asserting because m_fontReference is null when running e.g., 'svg/W3C-SVG-1.1/animate-elem-03-t.svg' Will investigate further.
Brent Fulgham
Comment 6 2015-01-20 14:58:57 PST
Debugging further, it looks like the buffer generated by convertSVGToOTFFont may be different in some way. If I pass this buffer through the Windows AddFontMemResourceEx method, it fails. However, the original code path works.
Brent Fulgham
Comment 7 2015-01-20 15:32:41 PST
It appears that only font data produced by the ENABLE(SVG_OTF_CONVERTER) code path in CSSFontFaceSource.cpp suffer from this issue (convertSVGToOTFFont).
Myles C. Maxfield
Comment 8 2015-01-20 17:51:52 PST
(In reply to comment #6) > Debugging further, it looks like the buffer generated by convertSVGToOTFFont > may be different in some way. > > If I pass this buffer through the Windows AddFontMemResourceEx method, it > fails. > > However, the original code path works. Different than what? By "original code path," do you mean "with the converter off?"
Brent Fulgham
Comment 9 2016-03-22 10:25:50 PDT
This patch is no longer needed. The feature was turned on in r197145 <http://trac.webkit.org/changeset/197145>.
Note You need to log in before you can comment on or make changes to this bug.