[SVG -> OTF Converter] Flip the switch on (Windows)
Created attachment 244999 [details]
Created attachment 245000 [details]
Comment on attachment 245000 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=245000&action=review
> + const unsigned featureCount = 5;
MSVC doesn't allow you to use a variable as the argument to an array declaration.
It looks like:
(1) We still have differences in SVG after turning this on.
(2) FontCustomPlatformData::fontPlatformData is asserting because m_fontReference is null when running e.g., 'svg/W3C-SVG-1.1/animate-elem-03-t.svg'
Will investigate further.
Debugging further, it looks like the buffer generated by convertSVGToOTFFont may be different in some way.
If I pass this buffer through the Windows AddFontMemResourceEx method, it fails.
However, the original code path works.
It appears that only font data produced by the ENABLE(SVG_OTF_CONVERTER) code path in CSSFontFaceSource.cpp suffer from this issue (convertSVGToOTFFont).
(In reply to comment #6)
> Debugging further, it looks like the buffer generated by convertSVGToOTFFont
> may be different in some way.
> If I pass this buffer through the Windows AddFontMemResourceEx method, it
> However, the original code path works.
Different than what?
By "original code path," do you mean "with the converter off?"
This patch is no longer needed. The feature was turned on in r197145 <http://trac.webkit.org/changeset/197145>.