Bug 140592 – [SVG -> OTF Converter] Flip the switch on

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[SVG -> OTF Converter] Flip the switch on

[Myles C. Maxfield]

Created attachment 244854 [details]
Patch

[WebKit Commit Bot]

Attachment 244854 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 62 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Myles C. Maxfield]

Comment on attachment 244854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244854&action=review

> Source/JavaScriptCore/ChangeLog:1
> [phone]  Myles C. Maxfield  <[e-mail]>

Wrong email.

[Myles C. Maxfield]

Created attachment 244873 [details]
Patch

[Antti Koivisto]

Comment on attachment 244873 [details]
Patch

Lets do this. r=me

[Radar WebKit Bug Importer]

<rdar://problem/19518776>

[WebKit Commit Bot]

Comment on attachment 244873 [details]
Patch

Clearing flags on attachment: 244873

Committed r178653: <http://trac.webkit.org/changeset/178653>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This broke a number of tests on Mountain Lion: <https://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r178654%20(23639)/results.html>

As discussed in person, will roll out for now.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 140634

[Myles C. Maxfield]

Committed with additional Mountain Lion results in http://trac.webkit.org/changeset/178691

[Csaba Osztrogonác]

(In reply to comment #11)
> Committed with additional Mountain Lion results in
> http://trac.webkit.org/changeset/178691

It broke tests on Apple Windows bot too.
before: https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/49126
after: https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/49127

[Myles C. Maxfield]

bfulgham: Do you know why this is? The patch only touches LayoutTests/platform/mac* and FeatureDefines.xcconfig files. Does windows use xcconfig files somehow?

[Csaba Osztrogonác]

(In reply to comment #13)
> bfulgham: Do you know why this is? The patch only touches
> LayoutTests/platform/mac* and FeatureDefines.xcconfig files. Does windows
> use xcconfig files somehow?

Ah, I think I got the problem:
"Baseline search path: win -> mac-mountainlion -> mac -> generic"

Windows use Mac results as fallback. It seems only the 
old results should be checked in to platform/win.

[Brent Fulgham]

(In reply to comment #14)
> (In reply to comment #13)
> > bfulgham: Do you know why this is? The patch only touches
> > LayoutTests/platform/mac* and FeatureDefines.xcconfig files. Does windows
> > use xcconfig files somehow?
> 
> Ah, I think I got the problem:
> "Baseline search path: win -> mac-mountainlion -> mac -> generic"
> 
> Windows use Mac results as fallback. It seems only the 
> old results should be checked in to platform/win.

Yes -- this is true. We try to reuse as much of the mac results as possible.

Are these changes being made to mac-mountainlion, too? If so, I guess we need to land new baselines (i.e., copy the old mac results to win).