ES6: Support Array.of construction

[Dean Jackson]

ES6: Support Array.of construction

[Dean Jackson]

<rdar://problem/19513655>

[Dean Jackson]

Created attachment 244877 [details]
Patch

[Geoffrey Garen]

Comment on attachment 244877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244877&action=review

r=me with two fixes below

> Source/JavaScriptCore/runtime/ArrayConstructor.cpp:55
> +  of        arrayConstructorOf          DontEnum|Function 1

Length should be 0, not 1.

> Source/JavaScriptCore/runtime/ArrayConstructor.cpp:139
> +        result->putDirectIndex(exec, i, args.at(i));

You should add a line to your testcase that verifies that Array.of does not invoke a setter for the index 0.

[Eric Carlson]

Comment on attachment 244877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244877&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        Add and implementation of Array.of, described in 22.1.2.3 of the ES6

Nit: "Add and" -> "Add an"

[Dean Jackson]

Committed r178662: <http://trac.webkit.org/changeset/178662>

[Dean Jackson]

(In reply to comment #4)
> 
> Nit: "Add and" -> "Add an"

Oops!

[Joseph Pecoraro]

*** Bug 131699 has been marked as a duplicate of this bug. ***