Bug 131699 - Simple ES6 feature: Array.of
Summary: Simple ES6 feature: Array.of
Status: RESOLVED DUPLICATE of bug 140605
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords: EasyFix, InRadar
Depends on:
Blocks:
 
Reported: 2014-04-15 14:57 PDT by Oliver Hunt
Modified: 2015-11-12 21:54 PST (History)
6 users (show)

See Also:

Attachments
Patch (11.55 KB, patch)
2014-04-18 16:41 PDT, Oliver Hunt 		ggaren: review+
Details | Formatted Diff | Diff
Patch (14.48 KB, patch)
2014-10-04 09:11 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (515.89 KB, application/zip)
2014-10-04 10:13 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (800.86 KB, application/zip)
2014-10-04 11:09 PDT, Build Bot 		no flags Details
Patch (18.27 KB, patch)
2014-10-04 11:46 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2014-04-15 14:57:02 PDT 
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-22.1.2.3

Should be doable in builtin JS
Comment 1 Radar WebKit Bug Importer 2014-04-15 14:57:21 PDT 
<rdar://problem/16625973>
Comment 2 Oliver Hunt 2014-04-18 16:41:06 PDT 
Created attachment 229683 [details]
Patch
Comment 3 Geoffrey Garen 2014-04-18 16:56:47 PDT 
Comment on attachment 229683 [details]
Patch

r=me
Comment 4 Diego Pino 2014-10-04 09:11:03 PDT 
Created attachment 239281 [details]
Patch
Comment 5 Diego Pino 2014-10-04 09:13:07 PDT 
I added more tests to the patch. I imported the Array.of tests from Mozilla and modified the implementation of Array.of() in order to pass the tests.
Comment 6 Build Bot 2014-10-04 10:13:48 PDT 
Comment on attachment 239281 [details]
Patch

Attachment 239281 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5841998703493120

New failing tests:
js/Object-getOwnPropertyNames.html
Comment 7 Build Bot 2014-10-04 10:13:51 PDT 
Created attachment 239282 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2014-10-04 11:09:14 PDT 
Comment on attachment 239281 [details]
Patch

Attachment 239281 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4617453329973248

New failing tests:
js/Object-getOwnPropertyNames.html
Comment 9 Build Bot 2014-10-04 11:09:18 PDT 
Created attachment 239283 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 Diego Pino 2014-10-04 11:46:58 PDT 
Created attachment 239284 [details]
Patch
Comment 11 Joseph Pecoraro 2015-11-12 21:54:11 PST 
Comment on attachment 239284 [details]
Patch

Clearing review flag. This patch seems stale as Array.of seems to have already landed as part of:
https://bugs.webkit.org/show_bug.cgi?id=140605
https://bugs.webkit.org/show_bug.cgi?id=145365

That said, the tests in this bug seem valuable. It may be worth creating a new bug + patch to add extra testing for Array.of.
Comment 12 Joseph Pecoraro 2015-11-12 21:54:28 PST 

*** This bug has been marked as a duplicate of bug 140605 ***