WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140602
Remove the SVG instance tree
https://bugs.webkit.org/show_bug.cgi?id=140602
Summary
Remove the SVG instance tree
Philip Rogers
Reported
2015-01-18 17:58:56 PST
Supporting the instance tree requires a lot of complexity and it can probably be removed without affecting any users. The instance tree was ahead of it's time (many of the same issues are on public-webapps right now!) but it never caught on with users. Chromium's usecounters found no usage of instanceRoot and it was removed entirely in mid-2014[1]. I'm not aware of any web compatibility fallout from removing it (not a single bug, AFAIK). There is support in the SVGWG for removing the instance tree in SVG2[2]. The instance tree was never implemented in Gecko. Removing the instance tree in blink took a few patches but most were mechanical. All the patches are listed on crbug.com/313438 and would be pretty easy to port to WebKit. [1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/mgYCJuzfU0Q/8jdhjY0pNgoJ
[2]
https://lists.w3.org/Archives/Public/www-svg/2014Jan/0014.html
Attachments
Patch
(109.68 KB, patch)
2015-02-08 15:52 PST
,
Darin Adler
dino
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2015-01-19 13:31:10 PST
Sounds good to me.
Sam Weinig
Comment 2
2015-01-19 17:34:50 PST
I'm fine with this as well.
Darin Adler
Comment 3
2015-01-20 08:21:26 PST
I’m going to take a crack at this.
Darin Adler
Comment 4
2015-01-20 08:40:31 PST
Investigating crbug.com/313438 further, it’s clear this is a pretty big project that Rob Buis did! But we can indeed take advantage of those patches and redo this for WebKit; it will be 10 or so patches to do it all. I am about to land a first patch.
Darin Adler
Comment 5
2015-02-08 15:52:30 PST
Created
attachment 246251
[details]
Patch
Darin Adler
Comment 6
2015-02-08 17:13:40 PST
Committed
r179810
: <
http://trac.webkit.org/changeset/179810
>
Chris Dumez
Comment 7
2015-02-09 10:12:02 PST
This may have caused a perf regression on the HTML5 full-render test: -
https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D
(Mavericks / 3.6% regression) -
https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22efl%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D
(EFL / 2.3% regression) I am not 100% sure it is caused by this change but the range on the EFL bot is small enough that I'd say it is very likely.
Chris Dumez
Comment 8
2015-02-09 10:18:03 PST
(In reply to
comment #7
)
> This may have caused a perf regression on the HTML5 full-render test: > - >
https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac
- > mavericks%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D (Mavericks / > 3.6% regression) > - >
https://perf.webkit.org/
> #mode=charts&chartList=%5B%5B%22efl%22%2C%22Parser%2Fhtml5-full- > render%3ATime%22%5D%5D (EFL / 2.3% regression) > > I am not 100% sure it is caused by this change but the range on the EFL bot > is small enough that I'd say it is very likely.
Looking at the change though, I really don't see what could have caused a regression. I think Ryosuke is planning to confirm the regression locally (may be a flake on the bot or another commit).
Darin Adler
Comment 9
2015-02-09 14:05:48 PST
Are there any SVG <use> elements in the full-render test?
Said Abou-Hallawa
Comment 10
2015-04-22 14:43:28 PDT
***
Bug 121050
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug