Bug 140599 - Generate matchingShorthandsForLonghand() implementation from CSSPropertyNames.in
Summary: Generate matchingShorthandsForLonghand() implementation from CSSPropertyNames.in
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
: 126049 (view as bug list)
Depends on: 140501
  Show dependency treegraph
Reported: 2015-01-18 15:53 PST by Chris Dumez
Modified: 2016-04-29 09:20 PDT (History)
6 users (show)

See Also:

Patch (15.67 KB, patch)
2015-01-18 18:27 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-18 15:53:53 PST
We should generate matchingShorthandsForLonghand() implementation from CSSPropertyNames.in. We already have all the information we need in CSSPropertyNames.in to generate the big switch() in matchingShorthandsForLonghand().
Comment 1 Chris Dumez 2015-01-18 18:27:04 PST
Created attachment 244870 [details]
Comment 2 Chris Dumez 2015-01-18 18:27:48 PST
Comment on attachment 244870 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=244870&action=review

> Source/WebCore/css/makeprop.pl:991
>  print SHORTHANDS_CPP << "EOF";

The generated code looks like:
Comment 3 WebKit Commit Bot 2015-01-18 18:28:28 PST
Attachment 244870 [details] did not pass style-queue:

ERROR: Source/WebCore/css/StylePropertyShorthand.h:91:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/css/StylePropertyShorthand.h:94:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/css/StylePropertyShorthand.h:97:  Missing space before {  [whitespace/braces] [5]
Total errors found: 3 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2015-01-18 20:51:30 PST
Comment on attachment 244870 [details]

Comment 5 WebKit Commit Bot 2015-01-18 21:32:26 PST
Comment on attachment 244870 [details]

Clearing flags on attachment: 244870

Committed r178638: <http://trac.webkit.org/changeset/178638>
Comment 6 WebKit Commit Bot 2015-01-18 21:32:30 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2016-04-29 09:20:35 PDT
*** Bug 126049 has been marked as a duplicate of this bug. ***