Bug 140477 – RenderLayerCompositor: Strange comparison of opacity to boolean.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Brent Fulgham]

I receive the following warning when I build. Reviewing the line in question reveals that we are comparing a boolean (the return value of "ancestorBacking->graphicsLayer->drawsContents()") to the float returned by the style's opacity property.

This seems very strange. At the very least, we should do some casting here to make it clear that this is intentional (if it is).

            if (newStyle.opacity() != ancestorBacking->graphicsLayer()->drawsContent())
                return true;

Where:
opacity is a float
drawsContent is a boolean.

[Brent Fulgham]

Based on Bug 138448, it looks like this was an intentional comparison, but I think a cast would make it clear that this is desired behavior.

[Simon Fraser (smfr)]

Agreed it's odd. Would be fine to clarify.

[Brent Fulgham]

I neglected to include the compiler error:

18>c:\projects\webkit\opensource\source\webcore\rendering\RenderLayerCompositor.cpp(888): warning C4805: '!=' : unsafe mix of type 'float' and type 'bool' in operation (..\rendering\RenderingAllInOne.cpp)

[Brent Fulgham]

This code is checking for non-zero opacity.

[Brent Fulgham]

Created attachment 244716 [details]
Patch

[Brent Fulgham]

Committed r178568: <http://trac.webkit.org/changeset/178568>