Bug 138448 - Avoid backing store for opacity:0 descendant layers
Summary: Avoid backing store for opacity:0 descendant layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 140477
  Show dependency tree / graph
 
Reported: 2014-11-05 18:06 PST by Simon Fraser (smfr)
Modified: 2015-01-14 16:25 PST (History)
7 users (show)

See Also:

Attachments
Patch (9.57 KB, patch)
2014-11-05 18:08 PST, Simon Fraser (smfr) 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-11-05 18:06:46 PST 
Avoid backing store for opacity:0 descendant layers
Comment 1 Simon Fraser (smfr) 2014-11-05 18:08:35 PST 
Created attachment 241079 [details]
Patch
Comment 2 Dean Jackson 2014-11-05 18:14:59 PST 
Comment on attachment 241079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241079&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:885
> +    if (!oldStyle.opacity() != !newStyle.opacity()) {

This is confuserating, but it makes sense after I thought about it for a while.

> LayoutTests/compositing/backing/toggle-opacity-0-child-expected.txt:1
> +FAIL: Timed out waiting for notifyDone to be called

WAT

> LayoutTests/compositing/backing/toggle-opacity-0-child.html:74
> +      <div id="child" class="child box">

child is both id and class. you could have used querySelector instead of getElementById
Comment 3 Simon Fraser (smfr) 2014-11-05 18:22:16 PST 
https://trac.webkit.org/r175656

rdar://problem/18869336