With UIWebView, it's possible to set, remove, and clear cookies using NSHTTPCookieStorage. WKWebView does not appear to interoperate with NSHTTPCookieStorage, and has no API for cookies. This makes it impossible to do things like: - Set authentication cookies from native code based on native login - Swap cookie stores for a multi-profile/-user setup Steps to Reproduce: N/A, but for example: - Create a trivial WKWebView app - Browser around - Log [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookies] and see that it's empty. Expected Results: Either NSHTTPCookieStorage working as expected (as it did with UIWebView), or WK* APIs for inspecting and manipulating cookies. Actual Results: No apparent way to interact with cookies.
Radar ID: 17486250
On iOS 8.3 I do get a list of cookies from NSHTTPCookieStorage().sharedHTTPCookieStorage().cookies but the results are unpredictable: Eventually I do get a list of cookies of sites that I visited but it seems there is a delay between cookies being available via NSHTTPCookieStorage. Setting a WKProcessPool made no difference. WKWebView probably syncs cookies back to the UI process on its own schedule. Not after each navigation.
*** Bug 158901 has been marked as a duplicate of this bug. ***
Have a patch that does this, but I'm not quite done with it, as I should make it handle the request in https://bugs.webkit.org/show_bug.cgi?id=140205 as well.
Created attachment 281607 [details] Patch v1 Meh, may as well review this one as is. I'll add 140205 functionality in a followup (and that patch will be much, much smaller)
Attachment 281607 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:119: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:53: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:48: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:138: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:144: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 9 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 281607 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=281607&action=review > Source/WebCore/ChangeLog:12 > + * platform/Cookie.h: This needs some explanation. You added three new member variables: comment, commentURL, ports. > Source/WebCore/platform/network/NetworkStorageSession.h:107 > +Vector<Cookie> NetworkStorageSession::getAllCookies() This needs to be inline after including Cookie.h, or in a cpp. I prefer the latter. > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:46 > + [webView loadHTMLString:@"Oh hello" baseURL:[NSURL URLWithString:@"http://webkit.org"]]; We should load some JavaScript that sets cookies and make sure that it shows up in the correct cookie storage.
(In reply to comment #7) > Comment on attachment 281607 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281607&action=review > > > Source/WebCore/ChangeLog:12 > > + * platform/Cookie.h: > > This needs some explanation. You added three new member variables: comment, > commentURL, ports. > It's pretty self explanatory in code, but I'll add a comment that explains what the code explains. > > Source/WebCore/platform/network/NetworkStorageSession.h:107 > > +Vector<Cookie> NetworkStorageSession::getAllCookies() > > This needs to be inline after including Cookie.h, or in a cpp. I prefer the > latter. > Hmmmm... yah, not sure why I built fine locally. > > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:46 > > + [webView loadHTMLString:@"Oh hello" baseURL:[NSURL URLWithString:@"http://webkit.org"]]; > > We should load some JavaScript that sets cookies and make sure that it shows > up in the correct cookie storage. Good idea.
Other changes I plan on making are making the set and get cookies methods take an optional completion handler. I'll get to these changes sometime soonish
(In reply to comment #9) > Other changes I plan on making are making the set and get cookies methods > take an optional completion handler. You mean set and delete? I was thinking about that, too. We might want info about what cookie was there before setting or deleting. Get with an optional completion handler wouldn't be very useful, though.
(In reply to comment #10) > (In reply to comment #9) > > Other changes I plan on making are making the set and get cookies methods > > take an optional completion handler. > You mean set and delete? I was thinking about that, too. We might want > info about what cookie was there before setting or deleting. Get with an > optional completion handler wouldn't be very useful, though. Yes, I meant set and delete. Get is taken care of. I'm not sure its useful to have info about the cookie that was set or deleted. Doesn't exist in the current NS-API, and it would slow down the whole set or delete operation, as we'd have to manually fetch. If clients were interested they could fetch ahead of time for themselves.
Comment on attachment 281607 [details] Patch v1 Yes, probably a good idea to conceptually match NSHTTPCookieStorage, but asynchronous obviously because everything's in a different process. What about removeCookiesSinceDate and getting/setting cookieAcceptPolicy?
(In reply to comment #12) > Comment on attachment 281607 [details] > Patch v1 > > Yes, probably a good idea to conceptually match NSHTTPCookieStorage, but > asynchronous obviously because everything's in a different process. What > about removeCookiesSinceDate and getting/setting cookieAcceptPolicy? https://bugs.webkit.org/show_bug.cgi?id=140191#c4 and https://bugs.webkit.org/show_bug.cgi?id=140191#c5 explain how I'll do the policy separately. I'll also file a followup for removeCookiesSinceData - Don't want to keep making this patch bigger when it's already not 100% of the task.
Comment on attachment 281607 [details] Patch v1 I don't think this should be a property on the WKWebView - it should be on the WKWebsiteDataStore - that's where all the other website data lives.
<rdar://problem/17486250>
Any plans to finish this? I guess we really need to make the new HTTPCookieStorage a property of WebsiteDataStore as Anders suggested, and also make it session ID aware. We could probably reuse WebCookieManagerProxy by adding a sessionID parameter to all the IPC messages. We use the default session ID in the old API implementation, and the WebsiteDataStore session ID in the new one. I can help with this if needed.
+1 having access to the WKWebView would enable single-sign-on support. We have had to downgrade to UIWebView because of this limitation.
(In reply to comment #16) > Any plans to finish this? Stay tuned. Waiting on a couple of other patches to work their way through CQ.
Created attachment 304213 [details] Not for review - Initial EWS run
Attachment 304213 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:309: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:314: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:319: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.cpp:62: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.cpp:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.cpp:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.cpp:109: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.cpp:122: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.cpp:135: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.cpp:161: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.h:46: The parameter name "sessionID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.h:48: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.h:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.h:53: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.h:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:733: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:733: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:72: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:200: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:215: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:237: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 61 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 304237 [details] Patch
Attachment 304237 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:309: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:314: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:319: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:733: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:733: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:64: The parameter name "websiteDataStore" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:200: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:215: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:237: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 44 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 304238 [details] Patch
Attachment 304238 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:309: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:314: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:319: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:733: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:733: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:64: The parameter name "websiteDataStore" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:175: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:209: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:246: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 46 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Will be adding much more extensive tests (as Alex had suggested last year, but also to cover the entire API), but this upcoming patch will be ready for review regardless
Created attachment 304242 [details] Patch for review
Attachment 304242 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:309: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:314: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:319: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:733: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:733: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:64: The parameter name "websiteDataStore" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:175: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:209: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:246: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 46 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 304242 [details] Patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=304242&action=review > Source/WebKit2/ChangeLog:8 > + This adds a new _WKHTTPCookieManager SPI. There is very little detail in this change log, but this one detail is wrong.
Created attachment 304255 [details] Patch
Attachment 304255 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:309: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:314: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:319: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:64: The parameter name "websiteDataStore" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:175: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:209: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:246: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 46 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 304261 [details] Patch
Attachment 304261 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:309: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:314: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:319: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:64: The parameter name "websiteDataStore" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:175: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:209: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:246: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 46 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.
I suggest preemptively wrapping the new SPI headers in NS_ASSUME_NONNULL_{BEGIN,END} (like all the API headers), and then removing all the “nonnull” specifiers.
Created attachment 304269 [details] Patch
Attachment 304269 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:309: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:314: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:319: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:64: The parameter name "websiteDataStore" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:175: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:209: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:246: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 46 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 304269 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304269&action=review > Source/WebKit2/UIProcess/API/Cocoa/_WKHTTPCookieStorage.mm:42 > + [nsCookies addObject:(NSHTTPCookie*)cookie]; Star's on the wrong side :P > Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:1151 > + // have a data store; They should. They > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:30 > +#if PLATFORM(MAC) Why Mac only? > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:46 > + auto window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:YES]); > + [[window contentView] addSubview:webView.get()]; Why do you need a window? If you do, can you use TestWKWebView?
Created attachment 304276 [details] Patch
Attachment 304276 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:175: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:209: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:246: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 42 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 304285 [details] Patch
Attachment 304285 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:175: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:209: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:246: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 42 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 304288 [details] Patch
Attachment 304288 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:175: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:209: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:246: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 42 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 304290 [details] Patch
Attachment 304290 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:175: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:209: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:246: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitCookieManager.cpp:182: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitCookieManager.cpp:182: Missing space inside { }. [whitespace/braces] [5] Total errors found: 44 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 304299 [details] Patch
Attachment 304299 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:175: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:209: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:246: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitCookieManager.cpp:182: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitCookieManager.cpp:182: Missing space inside { }. [whitespace/braces] [5] Total errors found: 44 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 304299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304299&action=review Also please address ggaren's offline comments. > Source/WebKit2/ChangeLog:10 > + After the implementation is landed and we review internally we'll consider promoting to API. Not necessarily a great changelog line. > Source/WebKit2/UIProcess/API/Cocoa/WKHTTPCookieStorage.h:53 > + @param cookies The cookie to set. Cookie*s*? > Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:122 > + // FIXME: We need to start to unravel this mess going forward. Please. > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:77 > + [cookieStorage setCookie:cookie1.get() completionHandler:nil]; > + [cookieStorage setCookie:cookie2.get() completionHandler:nil]; Seems like you should make sure these completion handlers get called! And also have tests for e.g. what happens if the web/network process dies while doing this, etc.
(In reply to comment #47) > Comment on attachment 304299 [details] > Patch > > > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:77 > > + [cookieStorage setCookie:cookie1.get() completionHandler:nil]; > > + [cookieStorage setCookie:cookie2.get() completionHandler:nil]; > > Seems like you should make sure these completion handlers get called! And > also have tests for e.g. what happens if the web/network process dies while > doing this, etc. I'll change this basic test to have completion handlers there. More edge case tests coming soon!
Created attachment 304314 [details] Patch
Attachment 304314 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:64: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKCookieManager.cpp:69: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:76: Missing space before { [whitespace/braces] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:737: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:199: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:166: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:175: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:209: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:246: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitCookieManager.cpp:182: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitCookieManager.cpp:182: Missing space inside { }. [whitespace/braces] [5] Total errors found: 46 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 304314 [details] Patch Clearing flags on attachment: 304314 Committed r213877: <http://trac.webkit.org/changeset/213877>
All reviewed patches have been landed. Closing bug.
Thank you again!
Committed r213879: <http://trac.webkit.org/changeset/213879>
(In reply to comment #51) > Comment on attachment 304314 [details] > Patch > > Clearing flags on attachment: 304314 > > Committed r213877: <http://trac.webkit.org/changeset/213877> This change appears to have caused API test WebKit2.CookieManager to fail with an assertion: https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/builds/11623/steps/run-api-tests/logs/stdio
(In reply to comment #55) > (In reply to comment #51) > > Comment on attachment 304314 [details] > > Patch > > > > Clearing flags on attachment: 304314 > > > > Committed r213877: <http://trac.webkit.org/changeset/213877> > > This change appears to have caused API test WebKit2.CookieManager to fail > with an assertion: > https://build.webkit.org/builders/ > Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/builds/11623/steps/run-api- > tests/logs/stdio Looking into it now. Please disable the test instead of rolling out if I can't resolve it quickly enough.
(In reply to comment #56) > (In reply to comment #55) > > (In reply to comment #51) > > > Comment on attachment 304314 [details] > > > Patch > > > > > > Clearing flags on attachment: 304314 > > > > > > Committed r213877: <http://trac.webkit.org/changeset/213877> > > > > This change appears to have caused API test WebKit2.CookieManager to fail > > with an assertion: > > https://build.webkit.org/builders/ > > Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/builds/11623/steps/run-api- > > tests/logs/stdio > > Looking into it now. Please disable the test instead of rolling out if I > can't resolve it quickly enough. There is something to be cleaned up here, but in the meantime it's a debug-only assert that doesn't cause a big problem in release builds. I'm going to disable the test for now because I probably won't be able to fix tonight, but will first thing tomorrow AM.
(In reply to comment #57) > (In reply to comment #56) > > (In reply to comment #55) > > > (In reply to comment #51) > > > > Comment on attachment 304314 [details] > > > > Patch > > > > > > > > Clearing flags on attachment: 304314 > > > > > > > > Committed r213877: <http://trac.webkit.org/changeset/213877> > > > > > > This change appears to have caused API test WebKit2.CookieManager to fail > > > with an assertion: > > > https://build.webkit.org/builders/ > > > Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/builds/11623/steps/run-api- > > > tests/logs/stdio > > > > Looking into it now. Please disable the test instead of rolling out if I > > can't resolve it quickly enough. > > There is something to be cleaned up here, but in the meantime it's a > debug-only assert that doesn't cause a big problem in release builds. > > I'm going to disable the test for now because I probably won't be able to > fix tonight, but will first thing tomorrow AM. Working on it over in https://bugs.webkit.org/show_bug.cgi?id=169581
(In reply to comment #51) > Comment on attachment 304314 [details] > Patch > > Clearing flags on attachment: 304314 > > Committed r213877: <http://trac.webkit.org/changeset/213877> It broke the Apple Mac cmake build: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/12991
Just wondering (sorry about the dup question) -- do you have any sense of when these patches will make themselves into iOS updates? Would clients need to have WebKit updated too or is it primarily on the iOS SDK side?
(In reply to rhu from comment #60) > Just wondering (sorry about the dup question) -- do you have any sense of > when these patches will make themselves into iOS updates? Apple doesn't comment on the timing/content of updates. > Would clients need to have WebKit updated too or is it primarily on the iOS SDK side? Things like this will certainly require the client to update.