WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140130
ADDRESS_SANITIZER macro is overloaded
https://bugs.webkit.org/show_bug.cgi?id=140130
Summary
ADDRESS_SANITIZER macro is overloaded
Alexey Proskuryakov
Reported
2015-01-06 10:48:06 PST
ADDRESS_SANITIZER macro is used for two purposes: - conditional compilation of code when ASan is enabled; - enabling security checks, whether ASan is enabled or not.
Attachments
proposed fix
(7.15 KB, patch)
2015-01-06 10:53 PST
,
Alexey Proskuryakov
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2015-01-06 10:53:23 PST
Created
attachment 244074
[details]
proposed fix
Anders Carlsson
Comment 2
2015-01-06 13:36:24 PST
Comment on
attachment 244074
[details]
proposed fix View in context:
https://bugs.webkit.org/attachment.cgi?id=244074&action=review
> Source/WTF/wtf/Compiler.h:143 > +#if defined(__has_feature) > +#define ASAN_ENABLED __has_feature(address_sanitizer) > +#else > +#define ASAN_ENABLED false > +#endif
Maybe this should be #define ENABLE_ASAN? so #if ENABLE(ASAN) could be used?
Alexey Proskuryakov
Comment 3
2015-01-06 14:13:13 PST
ENABLE() macros are for things that can be enabled by defining the macro, which is why I intentionally stayed away from using this form - ASan won't appear if you pass -DENABLE_ASAN.
Alexey Proskuryakov
Comment 4
2015-01-06 14:24:46 PST
Committed <
http://trac.webkit.org/r177995
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug