Bug 128819 - [ASan] Disable JSStack::sanitizeStack() to avoid false-positive stack-buffer-overflow errors
Summary: [ASan] Disable JSStack::sanitizeStack() to avoid false-positive stack-buffer-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-14 09:03 PST by David Kilzer (:ddkilzer)
Modified: 2015-01-06 10:48 PST (History)
3 users (show)

See Also:


Attachments
Patch for landing (1.69 KB, patch)
2014-02-14 09:05 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-02-14 09:03:15 PST
When building with the clang address sanitizer, don't sanitize the stack since it will trigger false-positive stack-buffer-overflow errors.  Disabling this only results in a performance penalty, not a correctness penalty.
Comment 1 David Kilzer (:ddkilzer) 2014-02-14 09:05:43 PST
Created attachment 224221 [details]
Patch for landing
Comment 2 David Kilzer (:ddkilzer) 2014-02-14 09:06:30 PST
<rdar://problem/16055903>
Comment 3 David Kilzer (:ddkilzer) 2014-02-14 09:07:00 PST
Committed r164102: <http://trac.webkit.org/changeset/164102>