Whitelist all directories that we search for NPAPI plugins.
Created attachment 243954 [details] Patch
Created attachment 249295 [details] [Linux] SeccompFilters: whitelist all NPAPI plugin directories
Created attachment 256703 [details] [Linux] SeccompFilters: whitelist all NPAPI plugin directories
Comment on attachment 256703 [details] [Linux] SeccompFilters: whitelist all NPAPI plugin directories (Looks like I need to update the copyright years in this patch.)
Comment on attachment 256703 [details] [Linux] SeccompFilters: whitelist all NPAPI plugin directories View in context: https://bugs.webkit.org/attachment.cgi?id=256703&action=review > Source/WebKit2/Shared/Plugins/unix/PluginSearchPath.cpp:37 > + Vector<String> result; This could be static, with the method returning a reference to the object, but it's not terribly important since it probably doesn't get called frequently.
Created attachment 256784 [details] Patch
Comment on attachment 256784 [details] Patch Clearing flags on attachment: 256784 Committed r186810: <http://trac.webkit.org/changeset/186810>
All reviewed patches have been landed. Closing bug.
(In reply to comment #5) > > Source/WebKit2/Shared/Plugins/unix/PluginSearchPath.cpp:37 > > + Vector<String> result; > > This could be static, with the method returning a reference to the object, > but it's not terribly important since it probably doesn't get called > frequently. Ahhh, missed that comment, I can do it in a follow-up.
(In reply to comment #9) > Ahhh, missed that comment, I can do it in a follow-up. I think I slightly prefer to not make it a static reference, since it's thread-safe this way. Also so that we don't have to change PluginInfoStore::pluginsDirectories (for us and for the Mac port) where it would otherwise get copied.
(In reply to comment #10) > (In reply to comment #9) > > Ahhh, missed that comment, I can do it in a follow-up. > > I think I slightly prefer to not make it a static reference, since it's > thread-safe this way. Also so that we don't have to change > PluginInfoStore::pluginsDirectories (for us and for the Mac port) where it > would otherwise get copied. OK, not a big issue.