RESOLVED FIXED 140061
fast/events/before-unload-adopt-subframe-to-outside.html is flaky with ASan 
https://bugs.webkit.org/show_bug.cgi?id=140061
Summary fast/events/before-unload-adopt-subframe-to-outside.html is flaky with ASan
Alexey Proskuryakov
Reported 2015-01-04 16:06:22 PST
I think that this is an issue with trailing whitespace similar to one in bug 126169. There is an iframe appended to body while an inline script runs, and a newline after </script> is parsed when the iframe is already in DOM tree. After that, another iframe is added. Depending on whether a layout happens before the second iframe is added, we get different render trees in the end.
Attachments
proposed fix (1.75 KB, patch)
2015-01-04 16:09 PST, Alexey Proskuryakov 		darin: review+
ap: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-mountainlion (596.46 KB, application/zip)
2015-01-04 16:30 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-mountainlion-wk2 (738.74 KB, application/zip)
2015-01-04 16:35 PST, Build Bot 		no flags
Details
proposed fix (2.10 KB, patch)
2015-01-05 23:22 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-01-04 16:09:10 PST
Created attachment 243946 [details] proposed fix
Alexey Proskuryakov
Comment 2 2015-01-04 16:28:02 PST
Comment on attachment 243946 [details] proposed fix Hmm, release builds seem unhappy about this change :(
Build Bot
Comment 3 2015-01-04 16:30:31 PST
Comment on attachment 243946 [details] proposed fix Attachment 243946 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5035683622158336 New failing tests: fast/events/before-unload-adopt-subframe-to-outside.html
Build Bot
Comment 4 2015-01-04 16:30:33 PST
Created attachment 243949 [details] Archive of layout-test-results from ews103 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 5 2015-01-04 16:35:54 PST
Comment on attachment 243946 [details] proposed fix Attachment 243946 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6465884109406208 New failing tests: fast/events/before-unload-adopt-subframe-to-outside.html
Build Bot
Comment 6 2015-01-04 16:35:57 PST
Created attachment 243950 [details] Archive of layout-test-results from ews106 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Alexey Proskuryakov
Comment 7 2015-01-05 23:22:17 PST
Created attachment 244036 [details] proposed fix Let's see what EWS thinks about this; it also fixes the test in my ASan build.
Alexey Proskuryakov
Comment 8 2015-01-06 00:04:41 PST
Comment on attachment 244036 [details] proposed fix EWS is green.
WebKit Commit Bot
Comment 9 2015-01-06 09:13:02 PST
Comment on attachment 244036 [details] proposed fix Clearing flags on attachment: 244036 Committed r177961: <http://trac.webkit.org/changeset/177961>
WebKit Commit Bot
Comment 10 2015-01-06 09:13:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.