Bug 126169 – REGRESSION: plugins/plugin-remove-readystatechange.html is failing on debug bots

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Alexey Proskuryakov]

plugins/plugin-remove-readystatechange.html became very flaky on debug bots recently, possibly because of lazy tree creation (the first failure is in r160911:r160914 range, just a few revisions after r160908).

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fplugin-remove-readystatechange.html

Looks like it's an extra blank line:

 ALERT: PASS: element could not be re-appended
 This test passes if it does not trip an assert in debug builds. It ensures a readystatechange event can't get dispatched until after a plugin is fully removed.
+

[Alexey Proskuryakov]

Darin had a related fix for this test in bug 130653, but that got rolled out.

I'm going to tweak the test to make it non-flaky, but it looks like a real bug in rendering code (that I have no idea how to fix).

When embed is the last rendered element in a document, and there is a newline after it, we create a renderer for the newline, and don't remove it when the embed is removed. But when there is no embed by the time the first layout occurs, the newline is ignored.

So, we get different render trees for the same DOM, depending on its history.

It's unfortunate that this bug hasn't been looked into in more than a year, even though the culprit was immediately identified.

[Alexey Proskuryakov]

Created attachment 243934 [details]
proposed fix

[Darin Adler]

(In reply to comment #1)
> It's unfortunate that this bug hasn't been looked into in more than a year,
> even though the culprit was immediately identified.

What was the culprit?

[Alexey Proskuryakov]

Comment on attachment 243934 [details]
proposed fix

> What was the culprit?

Not a specific culprit in code, but circumstantial evidence was pointing to <http://trac.webkit.org/changeset/160908>.

[WebKit Commit Bot]

Comment on attachment 243934 [details]
proposed fix

Clearing flags on attachment: 243934

Committed r177879: <http://trac.webkit.org/changeset/177879>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.