Bug 139752 - Fix the GTK build after r177452
Summary: Fix the GTK build after r177452
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Blocks: 139735
  Show dependency treegraph
Reported: 2014-12-17 15:36 PST by Csaba Osztrogonác
Modified: 2014-12-17 23:19 PST (History)
6 users (show)

See Also:

Patch (3.89 KB, patch)
2014-12-17 15:36 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-12-17 15:36:21 PST
Fix the GTK build after r177452
Comment 1 Csaba Osztrogonác 2014-12-17 15:36:38 PST
Created attachment 243465 [details]
Comment 2 WebKit Commit Bot 2014-12-17 15:38:29 PST
Attachment 243465 [details] did not pass style-queue:

ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Csaba Osztrogonác 2014-12-17 15:40:47 PST
I don't know what is PluginDatabase, if GTK really needs it or not, ...

It is only a speculative fix, which made the build happy. Feel free
to reuse this patch and fix it properly. Maybe removing code from
FrameLoader.cpp is absolutely incorrect, at least !COCOA&&!EFL&&!GTK 
port ( == WIN ? ).
Comment 4 Anders Carlsson 2014-12-17 16:59:22 PST
Thanks for the analysis! Turns out that FrameLoader::defaultObjectContentType is only used on Windows, so I'm going to move that code there.
Comment 5 Anders Carlsson 2014-12-17 17:56:58 PST
I got rid of the function in https://trac.webkit.org/r177482
Comment 6 Csaba Osztrogonác 2014-12-17 23:19:22 PST
cmake fix landed in https://trac.webkit.org/changeset/177488