Bug 139735 - Get rid of PluginPackageNone.cpp
Summary: Get rid of PluginPackageNone.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 139752
Blocks:
  Show dependency tree / graph
 
Reported: 2014-12-17 11:02 PST by Anders Carlsson
Modified: 2014-12-17 15:37 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.81 KB, patch)
2014-12-17 11:02 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-12-17 11:02:16 PST 
Get rid of PluginPackageNone.cpp
Comment 1 Anders Carlsson 2014-12-17 11:02:39 PST 
Created attachment 243444 [details]
Patch
Comment 2 Anders Carlsson 2014-12-17 12:09:46 PST 
Committed r177452: <http://trac.webkit.org/changeset/177452>
Comment 4 Anders Carlsson 2014-12-17 13:22:26 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > Committed r177452: <http://trac.webkit.org/changeset/177452>
> 
> This has broken the GTK build:
> https://build.webkit.org/builders/GTK%20Linux%2064-
> bit%20Release%20%28Build%29/builds/53722/steps/compile-webkit/logs/stdio

OK. EWS bot seems stuck. I don't think GTK+ needs to build PluginDatabase at all.
Comment 5 Csaba Osztrogonác 2014-12-17 15:32:29 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Committed r177452: <http://trac.webkit.org/changeset/177452>
> > 
> > This has broken the GTK build:
> > https://build.webkit.org/builders/GTK%20Linux%2064-
> > bit%20Release%20%28Build%29/builds/53722/steps/compile-webkit/logs/stdio
> 
> OK. EWS bot seems stuck. I don't think GTK+ needs to build PluginDatabase at
> all.

It seems PluginDatabase is used by GTK in FrameLoader.cpp in !PLATFORM(COCOA) && !PLATFORM(EFL) blocks.