Bug 139701 – Add layout test for animated GIFs in iframes moved in and out of the viewport using -webkit-transform

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Chris Dumez]

Add layout test for animated GIFs in iframes moved in and out of the viewport using -webkit-transform CSS property.

[Chris Dumez]

Created attachment 243390 [details]
Patch

[Chris Dumez]

Ping review

[Simon Fraser (smfr)]

Comment on attachment 243390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243390&action=review

> LayoutTests/fast/images/animated-gif-iframe-webkit-transform.html:58
> +function isFirstImagePaused() {
> +  var firstFrame = document.getElementById("testFrame1");
> +  return internals.hasPausedImageAnimations(firstFrame.contentDocument.getElementById('testImage'));
> +}
> +
> +function isSecondImagePaused() {
> +  var secondFrame = document.getElementById("testFrame2");
> +  return internals.hasPausedImageAnimations(secondFrame.contentDocument.getElementById('testImage'));
> +}
> +
> +function forceLayout() {
> +  document.getElementById("scroller-cont").offsetLeft;
> +}
> +
> +function checkSecondImageUnpaused() {
> +  shouldBecomeEqual("isSecondImagePaused()", "false", translateImagesRight);
> +}
> +
> +function checkSecondImagePaused() {
> +  shouldBecomeEqual("isSecondImagePaused()", "true", finishJSTest);
> +}
> +
> +function translateImagesLeft() {
> +  shouldBeFalse("isFirstImagePaused()");
> +  debug("Translating images left so that first image is no longer visible, but second image is.");
> +  forceLayout();
> +  document.getElementById("scroller-cont").style["-webkit-transform"] = "translate(-800px, 0px)";
> +  shouldBecomeEqual("isFirstImagePaused()", "true", checkSecondImageUnpaused);
> +}
> +
> +function translateImagesRight() {
> +  debug("Translating images right so that second image is no longer visible, but first image is.");
> +  forceLayout();
> +  document.getElementById("scroller-cont").style["-webkit-transform"] = "translate(0px, 0px)";
> +  shouldBecomeEqual("isFirstImagePaused()", "false", checkSecondImagePaused);
> +}

JS style is opening paren on new line.

[Chris Dumez]

Created attachment 244188 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 244188 [details]
Patch

Clearing flags on attachment: 244188

Committed r178053: <http://trac.webkit.org/changeset/178053>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.