Bug 139672 – REGRESSION (r163928): Animated GIFs are not resumed when translated into view using -webkit-transform

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Chris Dumez]

After r163928, animated GIFs are not resumed when translated into view using -webkit-transform CSS property.

This breaks animated gifs on the mobile version of weibo.com (which is one of the most popular blogging sites in China) on iPhone. e.g.
http://m.weibo.cn/page/tpl?containerid=1005052150182731_-_WEIBO_SECOND_PROFILE_WEIBO&itemid=&title=全部微博

Radar: <rdar://problem/19260797>

[Chris Dumez]

Reproduction case:
http://jsfiddle.net/k9qn8n5w/22/

[Chris Dumez]

Created attachment 243352 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 243352 [details]
Patch

Clearing flags on attachment: 243352

Committed r177360: <http://trac.webkit.org/changeset/177360>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

Comment on attachment 243352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243352&action=review

> Source/WebCore/dom/Document.cpp:1820
> +    frameView.resumeVisibleImageAnimationsIncludingSubframes();

Do you have a test for animated GIF in a subframe, and then moving the iframe's location using position or transform?

[Chris Dumez]

Comment on attachment 243352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243352&action=review

>> Source/WebCore/dom/Document.cpp:1820
>> +    frameView.resumeVisibleImageAnimationsIncludingSubframes();
> 
> Do you have a test for animated GIF in a subframe, and then moving the iframe's location using position or transform?

No, I don't think we have such test yet. I will add coverage for this case soon, I believe the current code should handle this fine though.

[Chris Dumez]

(In reply to comment #5)
> Comment on attachment 243352 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243352&action=review
> 
> > Source/WebCore/dom/Document.cpp:1820
> > +    frameView.resumeVisibleImageAnimationsIncludingSubframes();
> 
> Do you have a test for animated GIF in a subframe, and then moving the
> iframe's location using position or transform?

https://bugs.webkit.org/show_bug.cgi?id=139701