Bug 139668 - Move WebCore/platform/image-decoders to std::unique_ptr<>
Summary: Move WebCore/platform/image-decoders to std::unique_ptr<>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 128007
  Show dependency treegraph
 
Reported: 2014-12-15 20:17 PST by Gyuyoung Kim
Modified: 2014-12-16 18:24 PST (History)
1 user (show)

See Also:


Attachments
Patch (16.53 KB, patch)
2014-12-15 20:19 PST, Gyuyoung Kim
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-12-15 20:17:23 PST
SSIA
Comment 1 Gyuyoung Kim 2014-12-15 20:19:03 PST
Created attachment 243339 [details]
Patch
Comment 2 Andreas Kling 2014-12-16 18:07:45 PST
Comment on attachment 243339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243339&action=review

r=me

> Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:144
> +        typedef Vector<std::unique_ptr<BMPImageReader> > BMPReaders;

Templates can end in ">>" nowadays, no need for "> >"

> Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:146
> +        typedef Vector<std::unique_ptr<PNGImageDecoder> > PNGDecoders;

Ditto.
Comment 3 Gyuyoung Kim 2014-12-16 18:11:19 PST
Committed r177423: <http://trac.webkit.org/changeset/177423>
Comment 4 Gyuyoung Kim 2014-12-16 18:24:23 PST
(In reply to comment #2)
> Comment on attachment 243339 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243339&action=review
> 
> r=me
> 
> > Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:144
> > +        typedef Vector<std::unique_ptr<BMPImageReader> > BMPReaders;
> 
> Templates can end in ">>" nowadays, no need for "> >"
> 
> > Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:146
> > +        typedef Vector<std::unique_ptr<PNGImageDecoder> > PNGDecoders;
> 
> Ditto.

Fixed all, Thanks.