Bug 139516 – Switch to comparing PLATFORM_NAME in terms of macosx

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[David Kilzer (:ddkilzer)]

Switch to comparing PLATFORM_NAME in terms of macosx instead of iOS SDK names.

See also:
Bug 138813: FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
Bug 139212: Switch from using PLATFORM_NAME to SDK selectors in ANGLE, bmalloc, gtest, JavaScriptCore, WTF
Bug 139463: Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2

[David Kilzer (:ddkilzer)]

Created attachment 243082 [details]
Patch v1 (Testing build; DO NOT REVIEW YET unless it passes)

[David Kilzer (:ddkilzer)]

Comment on attachment 243082 [details]
Patch v1 (Testing build; DO NOT REVIEW YET unless it passes)

View in context: https://bugs.webkit.org/attachment.cgi?id=243082&action=review

> Source/WebKit/mac/migrate-headers.sh:32
> +    export WEBCORE_PRIVATE_HEADERS_DIR="`eval 'echo ${WEBCORE_PRIVATE_HEADERS_DIR_Production}'`"

This change really belongs with Bug 139516.

[David Kilzer (:ddkilzer)]

Created attachment 243607 [details]
Patch v2 (please review)

[Timothy Hatcher]

Comment on attachment 243607 [details]
Patch v2 (please review)

View in context: https://bugs.webkit.org/attachment.cgi?id=243607&action=review

> Source/WebKit/mac/MigrateHeaders.make:193
> -ifneq ($(filter iphoneos iphonesimulator, $(PLATFORM_NAME)), )
> +ifneq ($(filter macosx, $(PLATFORM_NAME)),macosx)

I this correct? I would have expected ifneq to change to ifeq here. A space before the last macosx would be good too.

[David Kilzer (:ddkilzer)]

Comment on attachment 243607 [details]
Patch v2 (please review)

View in context: https://bugs.webkit.org/attachment.cgi?id=243607&action=review

>> Source/WebKit/mac/MigrateHeaders.make:193
>> +ifneq ($(filter macosx, $(PLATFORM_NAME)),macosx)
> 
> I this correct? I would have expected ifneq to change to ifeq here. A space before the last macosx would be good too.

Will simplify this to the following before landing:

ifneq ($(PLATFORM_NAME), macosx)

[David Kilzer (:ddkilzer)]

Committed r178753: <http://trac.webkit.org/changeset/178753>

(In reply to comment #6)
> Committed r178753: <http://trac.webkit.org/changeset/178753>

This caused bug 144311.