Bug 138813 - FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
Summary: FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks: 139286
  Show dependency tree / graph
 
Reported: 2014-11-17 16:45 PST by David Kilzer (:ddkilzer)
Modified: 2014-12-04 21:14 PST (History)
7 users (show)

See Also:

Attachments
Patch v1 (100.32 KB, patch)
2014-11-18 12:44 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-11-17 16:45:50 PST 
Instead of using PLATFORM_NAME to define features in FeatureDefines.xcconfig, we should use [sdk=*] selectors since they are less verbose and more concise.
Comment 1 David Kilzer (:ddkilzer) 2014-11-18 12:44:44 PST 
Created attachment 241805 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-11-18 18:42:46 PST 
Comment on attachment 241805 [details]
Patch v1

Clearing flags on attachment: 241805

Committed r176303: <http://trac.webkit.org/changeset/176303>
Comment 3 WebKit Commit Bot 2014-11-18 18:42:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 David Kilzer (:ddkilzer) 2014-12-04 21:14:16 PST 
(In reply to comment #2)
> Comment on attachment 241805 [details]
> Patch v1
> 
> Clearing flags on attachment: 241805
> 
> Committed r176303: <http://trac.webkit.org/changeset/176303>

Filed this follow-up bug to track landing a workaround for 10.8 systems with Xcode 5.1.1:

Bug 139286: FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY