WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139286
FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
https://bugs.webkit.org/show_bug.cgi?id=139286
Summary
FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_W...
David Kilzer (:ddkilzer)
Reported
2014-12-04 21:13:08 PST
Xcode 5.1.1 has a bug where using an SDK selector ([sdk=macosx*]) on the LHS of a variable definition and a sub-variable expression on the RHS causes the entire expression to be ignored. In other words, when building with Xcode 5.1.1 on 10.8, this line in FeatureDefines.xcconfig is completely ignored: ENABLE_WEB_REPLAY[sdk=macosx*] = $(ENABLE_WEB_REPLAY_macosx_$(CONFIGURATION)); The workaround is to switch back to using PLATFORM_NAME and remove the SDK selector as long as 10.8 is supported.
Attachments
Patch v1
(6.54 KB, patch)
2014-12-04 21:19 PST
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2014-12-04 21:19:14 PST
Created
attachment 242615
[details]
Patch v1
WebKit Commit Bot
Comment 2
2014-12-05 09:55:03 PST
Comment on
attachment 242615
[details]
Patch v1 Clearing flags on attachment: 242615 Committed
r176846
: <
http://trac.webkit.org/changeset/176846
>
WebKit Commit Bot
Comment 3
2014-12-05 09:55:06 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug