Bug 139290 - Fix build warning in WebCore/platform/graphics module
Summary: Fix build warning in WebCore/platform/graphics module
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-12-04 22:03 PST by Shivakumar J M
Modified: 2014-12-05 02:29 PST (History)
6 users (show)

See Also:

Patch (1.56 KB, patch)
2014-12-04 22:07 PST, Shivakumar J M
cgarcia: review-
cgarcia: commit-queue-
Details | Formatted Diff | Diff
Patch-Updated-Review1 (2.11 KB, patch)
2014-12-05 01:05 PST, Shivakumar J M
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shivakumar J M 2014-12-04 22:03:31 PST
fix build warning in: [3342/5071] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/JSRTCDataChannelEvent.cpp.o
../../Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:115:15: warning: unused parameter ‘fontDescription’ [-Wunused-parameter]
 static String getFamilyNameStringFromFontDescriptionAndFamily(const FontDescription& fontDescription, const AtomicString& family)
Comment 1 Shivakumar J M 2014-12-04 22:07:46 PST
Created attachment 242617 [details]

Fix a build warning by removing parameter name from function.
Comment 2 Shivakumar J M 2014-12-04 22:16:42 PST
Might be caused by patch from bug: https://bugs.webkit.org/show_bug.cgi?id=139207
Comment 3 Carlos Garcia Campos 2014-12-04 23:26:21 PST
Comment on attachment 242617 [details]

getFamilyNameStringFromFontDescriptionAndFamily() is a private function, we should change it instead. If the font description is no longer used, the name is not true. So, I think it would be better to rename the function as something like getFamilyNameStringFromFamily() and remove the FontDescription parameter.
Comment 4 Shivakumar J M 2014-12-05 01:05:29 PST
Created attachment 242623 [details]

updated the patch as per comments
Comment 5 WebKit Commit Bot 2014-12-05 02:29:03 PST
Comment on attachment 242623 [details]

Clearing flags on attachment: 242623

Committed r176840: <http://trac.webkit.org/changeset/176840>
Comment 6 WebKit Commit Bot 2014-12-05 02:29:09 PST
All reviewed patches have been landed.  Closing bug.