Bug 139290 – Fix build warning in WebCore/platform/graphics module

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Shivakumar J M]

fix build warning in: [3342/5071] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/JSRTCDataChannelEvent.cpp.o
../../Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:115:15: warning: unused parameter ‘fontDescription’ [-Wunused-parameter]
 static String getFamilyNameStringFromFontDescriptionAndFamily(const FontDescription& fontDescription, const AtomicString& family)
               ^

[Shivakumar J M]

Created attachment 242617 [details]
Patch

Fix a build warning by removing parameter name from function.

[Shivakumar J M]

Might be caused by patch from bug: https://bugs.webkit.org/show_bug.cgi?id=139207

[Carlos Garcia Campos]

Comment on attachment 242617 [details]
Patch

getFamilyNameStringFromFontDescriptionAndFamily() is a private function, we should change it instead. If the font description is no longer used, the name is not true. So, I think it would be better to rename the function as something like getFamilyNameStringFromFamily() and remove the FontDescription parameter.

[Shivakumar J M]

Created attachment 242623 [details]
Patch-Updated-Review1

updated the patch as per comments

[WebKit Commit Bot]

Comment on attachment 242623 [details]
Patch-Updated-Review1

Clearing flags on attachment: 242623

Committed r176840: <http://trac.webkit.org/changeset/176840>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.