RESOLVED FIXED 139207
Remove genericFamily enum from FontDescription 
https://bugs.webkit.org/show_bug.cgi?id=139207
Summary Remove genericFamily enum from FontDescription
Antti Koivisto
Reported 2014-12-02 15:48:46 PST
It isn't really needed.
Attachments
patch (17.21 KB, patch)
2014-12-02 16:06 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
rebased (17.72 KB, patch)
2014-12-03 05:46 PST, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (700.59 KB, application/zip)
2014-12-03 06:54 PST, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (769.29 KB, application/zip)
2014-12-03 07:38 PST, Build Bot 		no flags
Details
another (20.46 KB, patch)
2014-12-03 09:24 PST, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (542.02 KB, application/zip)
2014-12-03 10:51 PST, Build Bot 		no flags
Details
another (21.83 KB, patch)
2014-12-03 11:06 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
win/efl build fixes (25.93 KB, patch)
2014-12-03 12:18 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-12-02 16:06:56 PST
Created attachment 242461 [details] patch
Andreas Kling
Comment 2 2014-12-02 16:39:36 PST
Comment on attachment 242461 [details] patch r=me but you'll need to rebaseline this.
Antti Koivisto
Comment 3 2014-12-03 05:46:13 PST
Created attachment 242488 [details] rebased
Build Bot
Comment 4 2014-12-03 06:54:49 PST
Comment on attachment 242488 [details] rebased Attachment 242488 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4516261820104704 New failing tests: fast/forms/control-restrict-line-height.html fast/ruby/nested-ruby.html fast/text/international/002.html fast/text/international/lang-sensitive-fonts-xml.xhtml fast/text/international/locale-sensitive-fonts.html platform/mac/fonts/han-disunification.html fast/text/international/lang-sensitive-fonts.html fast/text/international/jpan-script-equivalence.html
Build Bot
Comment 5 2014-12-03 06:54:51 PST
Created attachment 242489 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 6 2014-12-03 07:38:02 PST
Comment on attachment 242488 [details] rebased Attachment 242488 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6601692854353920 New failing tests: fast/forms/control-restrict-line-height.html fast/ruby/nested-ruby.html fast/text/international/002.html fast/text/international/lang-sensitive-fonts-xml.xhtml fast/text/international/locale-sensitive-fonts.html platform/mac/fonts/han-disunification.html fast/text/international/lang-sensitive-fonts.html fast/text/international/jpan-script-equivalence.html
Build Bot
Comment 7 2014-12-03 07:38:06 PST
Created attachment 242491 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Antti Koivisto
Comment 8 2014-12-03 09:24:47 PST
Created attachment 242497 [details] another
WebKit Commit Bot
Comment 9 2014-12-03 09:27:15 PST
Attachment 242497 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSFontSelector.cpp:376: Extra space between return and settings [whitespace/declaration] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 10 2014-12-03 10:51:29 PST
Comment on attachment 242497 [details] another Attachment 242497 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5298427978055680 New failing tests: fast/forms/control-restrict-line-height.html
Build Bot
Comment 11 2014-12-03 10:51:32 PST
Created attachment 242502 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Antti Koivisto
Comment 12 2014-12-03 11:06:20 PST
Created attachment 242505 [details] another
Antti Koivisto
Comment 13 2014-12-03 12:18:41 PST
Created attachment 242512 [details] win/efl build fixes
Antti Koivisto
Comment 14 2014-12-03 13:02:25 PST
https://trac.webkit.org/r176751
Note You need to log in before you can comment on or make changes to this bug.