Bug 139140 - Take into consideration canvas drawing for throttling DOM timers
Summary: Take into consideration canvas drawing for throttling DOM timers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
: 139054 (view as bug list)
Depends on: 139812
Blocks: 138292
  Show dependency treegraph
 
Reported: 2014-12-01 11:32 PST by Chris Dumez
Modified: 2014-12-19 00:35 PST (History)
8 users (show)

See Also:


Attachments
Patch (12.63 KB, patch)
2014-12-01 12:35 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-12-01 11:32:26 PST
We should take into consideration canvas drawing for throttling DOM timers.

This will:
- Fix cases where the DOMTimer would be throttled even though it is drawing on a canvas (e.g. http://hint.fm/wind)
- Use less CPU when the canvas being drawn onto is outside the viewport.

Radar:
<rdar://problem/19102218>
Comment 1 Chris Dumez 2014-12-01 12:35:39 PST
Created attachment 242329 [details]
Patch
Comment 2 Andreas Kling 2014-12-01 15:27:21 PST
Comment on attachment 242329 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-12-01 16:09:32 PST
Comment on attachment 242329 [details]
Patch

Clearing flags on attachment: 242329

Committed r176609: <http://trac.webkit.org/changeset/176609>
Comment 4 WebKit Commit Bot 2014-12-01 16:09:38 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2014-12-02 00:06:02 PST
What was the reason to have this fixed in a new bug, not in bug 139054 where the problem was reported? It is usually best to associate fixes with original reports.
Comment 6 Alexey Proskuryakov 2014-12-02 00:08:27 PST
*** Bug 139054 has been marked as a duplicate of this bug. ***
Comment 7 Chris Dumez 2014-12-02 08:03:44 PST
(In reply to comment #5)
> What was the reason to have this fixed in a new bug, not in bug 139054 where
> the problem was reported? It is usually best to associate fixes with
> original reports.

Sorry, I was only aware of the radar. Otherwise I wouldn't have bothered to create a new report.