Bug 139120 - [EFL] Add eldbus to the library list
Summary: [EFL] Add eldbus to the library list
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jaehun Lim
URL:
Keywords:
Depends on: 136355
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-30 22:38 PST by Jaehun Lim
Modified: 2014-12-01 00:10 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2014-11-30 22:40 PST, Jaehun Lim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaehun Lim 2014-11-30 22:38:45 PST 
Fix undefined reference errors for eldbus APIs.

../../Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:139: error: undefined reference to 'eldbus_init'
../../Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:159: error: undefined reference to 'eldbus_shutdown'
../../Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:182: error: undefined reference to 'eldbus_shutdown'
Comment 1 Jaehun Lim 2014-11-30 22:40:35 PST 
Created attachment 242304 [details]
Patch
Comment 2 Gyuyoung Kim 2014-11-30 22:49:34 PST 
Comment on attachment 242304 [details]
Patch

I wonder why this build error didn't happen on Bug 136355's EFL EWS.
Comment 3 Ryuan Choi 2014-11-30 23:22:31 PST 
(In reply to comment #1)
> Created attachment 242304 [details]
> Patch

Thanks.
Your patch is reasonable to me but I don't know why this is not happen on my PC.

Do you use SHARED_CORE?
Comment 4 Jaehun Lim 2014-11-30 23:35:57 PST 
Yes, I used SHARED_CORE at that time.
Comment 5 WebKit Commit Bot 2014-11-30 23:36:21 PST 
Comment on attachment 242304 [details]
Patch

Clearing flags on attachment: 242304

Committed r176590: <http://trac.webkit.org/changeset/176590>
Comment 6 WebKit Commit Bot 2014-11-30 23:36:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Gyuyoung Kim 2014-12-01 00:09:45 PST 
(In reply to comment #4)
> Yes, I used SHARED_CORE at that time.

Ah, that's why EFL EWS didn't detect this build break. EFL buildbots and EWS don't use SHARED_CORE option.
Comment 8 Gyuyoung Kim 2014-12-01 00:10:20 PST 
(In reply to comment #7)
> (In reply to comment #4)
> > Yes, I used SHARED_CORE at that time.
> 
> Ah, that's why EFL EWS didn't detect this build break. EFL buildbots and EWS
> don't use SHARED_CORE option.

It would be nicer if you mention this break occurs when SHARED_CORE is ON.