Bug 139081 - [WK2] SecComp buildfix after r176452
Summary: [WK2] SecComp buildfix after r176452
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 139239
Blocks: 138963
  Show dependency treegraph
 
Reported: 2014-11-27 13:42 PST by Csaba Osztrogonác
Modified: 2016-05-10 08:12 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.87 KB, patch)
2014-11-27 13:45 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-11-27 13:42:03 PST
https://trac.webkit.org/changeset/176452 broke the seccomp build:

../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:208:9: error: no matching function for call to 'sendMessage'
    if (sendMessage(m_socket, encoder->buffer(), encoder->bufferSize()) < 0)
        ^~~~~~~~~~~
../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:71:16: note: candidate function not viable: no known conversion from 'const uint8_t *' (aka 'const unsigned char *') to 'void *' for 2nd argument
static ssize_t sendMessage(int socket, void* data, size_t size, int fd = -1)
               ^
../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:343:13: error: no matching function for call to 'sendMessage'
        if (sendMessage(socket, encoder->buffer(), encoder->bufferSize(), fd) < 0)
            ^~~~~~~~~~~
../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:71:16: note: candidate function not viable: no known conversion from 'const uint8_t *' (aka 'const unsigned char *') to 'void *' for 2nd argument
static ssize_t sendMessage(int socket, void* data, size_t size, int fd = -1)
               ^
2 errors generated.
Comment 1 Csaba Osztrogonác 2014-11-27 13:45:53 PST
Created attachment 242258 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-28 01:10:25 PST
Comment on attachment 242258 [details]
Patch

Clearing flags on attachment: 242258

Committed r176559: <http://trac.webkit.org/changeset/176559>
Comment 3 WebKit Commit Bot 2014-11-28 01:10:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Commit Bot 2014-12-03 16:08:49 PST
Re-opened since this is blocked by bug 139239
Comment 5 Csaba Osztrogonác 2016-05-10 08:12:54 PDT
There is no seccomp in WebKit anymore, let's close it.