WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139009
Use std::unique_ptr instead of OwnPtr in JSC classes
https://bugs.webkit.org/show_bug.cgi?id=139009
Summary
Use std::unique_ptr instead of OwnPtr in JSC classes
Gyuyoung Kim
Reported
2014-11-22 18:16:02 PST
SSIA
Attachments
Patch
(14.84 KB, patch)
2014-11-22 18:17 PST
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Patch
(14.19 KB, patch)
2014-11-23 02:21 PST
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Patch for landing
(12.34 KB, patch)
2014-11-26 06:39 PST
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1
2014-11-22 18:17:59 PST
Created
attachment 242127
[details]
Patch
Gyuyoung Kim
Comment 2
2014-11-23 02:21:24 PST
Created
attachment 242132
[details]
Patch
Gyuyoung Kim
Comment 3
2014-11-24 17:50:08 PST
CC'ing Filip, could you take a look this patch ? (It was hard to ping you on IRC. So I add you to CC)
Gyuyoung Kim
Comment 4
2014-11-26 04:34:05 PST
Pizlo, could you take a look this as well ?
WebKit Commit Bot
Comment 5
2014-11-26 05:32:26 PST
Comment on
attachment 242132
[details]
Patch Rejecting
attachment 242132
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 242132, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: vaScriptCore/inspector/ContentSearchUtilities.cpp.rej patching file Source/JavaScriptCore/runtime/RegExp.cpp patching file Source/JavaScriptCore/runtime/RegExp.h patching file Source/JavaScriptCore/yarr/RegularExpression.cpp patching file Source/JavaScriptCore/yarr/YarrInterpreter.cpp patching file Source/JavaScriptCore/yarr/YarrInterpreter.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.appspot.com/results/6042494890409984
Gyuyoung Kim
Comment 6
2014-11-26 06:39:05 PST
Created
attachment 242227
[details]
Patch for landing
WebKit Commit Bot
Comment 7
2014-11-26 17:03:07 PST
Comment on
attachment 242227
[details]
Patch for landing Rejecting
attachment 242227
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242227, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t.org/repository/webkit/trunk ... Authentication realm: <
http://svn.webkit.org:80
> Mac OS Forge Password for '
commit-queue@webkit.org
': Authentication realm: <
http://svn.webkit.org:80
> Mac OS Forge Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114. error: git-svn died of signal 11 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output:
http://webkit-queues.appspot.com/results/4572464151527424
Gyuyoung Kim
Comment 8
2014-11-27 16:51:21 PST
Comment on
attachment 242227
[details]
Patch for landing Clearing flags on attachment: 242227 Committed
r176553
: <
http://trac.webkit.org/changeset/176553
>
Gyuyoung Kim
Comment 9
2014-11-27 16:51:29 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug