Bug 138865 – [EFL] REGRESSION(176066): It made all performance tests fail

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

before: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/3764
after: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/3765

After https://trac.webkit.org/changeset/176066 performance tests fail with EFL 1.11 and 1.12 too.
( https://trac.webkit.org/changeset/176196 bumped EFL version to 1.12 )

[Csaba Osztrogonác]

Any idea what is the problem with r176066 and how to fix it?

[Gyuyoung Kim]

(In reply to comment #1)
> Any idea what is the problem with r176066 and how to fix it?

If we can't find it now, I think we have to revert it.

[Csaba Osztrogonác]

(In reply to comment #2)
> (In reply to comment #1)
> > Any idea what is the problem with r176066 and how to fix it?
> If we can't find it now, I think we have to revert it.

Unfortunaltely bumping EFL to 1.12 depends on r176066,
so we should try to avoid reverting them.

[Gyuyoung Kim]

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Any idea what is the problem with r176066 and how to fix it?
> > If we can't find it now, I think we have to revert it.
> 
> Unfortunaltely bumping EFL to 1.12 depends on r176066,
> so we should try to avoid reverting them.

ok, Ryuan's patch might be reason of test failures. Ryuan, can you check it ?

[Gyuyoung Kim]

When I run performance test locally using below command, all tests are failures regardless of r176066. I will run performance test without EFL 1.12.


$> ./Tools/Scripts/run-perf-tests --platform=efl --release --webkit-test-runner

Running Bindings/document-implementation.html (4 of 141)
error: Bindings/document-implementation.html
ERR<23647>:evas_main lib/evas/canvas/evas_gl.c:42 evas_gl_new() Evas GL engine not available.
ERR<23657>: lib/eina/eina_module.c:263 eina_module_new() safety check failed: len > 0 is false
ERR<23647>:efreet_cache lib/efreet/efreet_cache.c:1108 on_send_register() org.freedesktop.DBus.Error.ServiceUnknown The name org.enlightenment.Efreet was not provided by any .service files

FAILED
Finished: 6.731030 s

[Csaba Osztrogonác]

(In reply to comment #5)
> When I run performance test locally using below command, all tests are
> failures regardless of r176066. I will run performance test without EFL 1.12.
> 
> 
> $> ./Tools/Scripts/run-perf-tests --platform=efl --release
> --webkit-test-runner
> 
> Running Bindings/document-implementation.html (4 of 141)
> error: Bindings/document-implementation.html
> ERR<23647>:evas_main lib/evas/canvas/evas_gl.c:42 evas_gl_new() Evas GL
> engine not available.
> ERR<23657>: lib/eina/eina_module.c:263 eina_module_new() safety check
> failed: len > 0 is false
> ERR<23647>:efreet_cache lib/efreet/efreet_cache.c:1108 on_send_register()
> org.freedesktop.DBus.Error.ServiceUnknown The name org.enlightenment.Efreet
> was not provided by any .service files
> 
> FAILED
> Finished: 6.731030 s

Have you set the hacky symlinks to make it work? ( bug134023 )

[Ryuan Choi]

Created attachment 242165 [details]
Patch

[Ryuan Choi]

(In reply to comment #0)
> before:
> https://build.webkit.org/builders/EFL%20Linux%2064-
> bit%20Release%20WK2%20%28Perf%29/builds/3764
> after:
> https://build.webkit.org/builders/EFL%20Linux%2064-
> bit%20Release%20WK2%20%28Perf%29/builds/3765
> 
> After https://trac.webkit.org/changeset/176066 performance tests fail with
> EFL 1.11 and 1.12 too.
> ( https://trac.webkit.org/changeset/176196 bumped EFL version to 1.12 )

Sorry, I was little bit busy.

It's because of destruction order between Evas_GL and Evas_GL_Surface.

[Ryuan Choi]

(In reply to comment #6)
> (In reply to comment #5)
> > When I run performance test locally using below command, all tests are
> > failures regardless of r176066. I will run performance test without EFL 1.12.
> > 
> > 
> > $> ./Tools/Scripts/run-perf-tests --platform=efl --release
> > --webkit-test-runner
> > 
> > Running Bindings/document-implementation.html (4 of 141)
> > error: Bindings/document-implementation.html
> > ERR<23647>:evas_main lib/evas/canvas/evas_gl.c:42 evas_gl_new() Evas GL
> > engine not available.
> > ERR<23657>: lib/eina/eina_module.c:263 eina_module_new() safety check
> > failed: len > 0 is false
> > ERR<23647>:efreet_cache lib/efreet/efreet_cache.c:1108 on_send_register()
> > org.freedesktop.DBus.Error.ServiceUnknown The name org.enlightenment.Efreet
> > was not provided by any .service files
> > 
> > FAILED
> > Finished: 6.731030 s
> 
> Have you set the hacky symlinks to make it work? ( bug134023 )

Or, below might be required to run run-perf-tests in a local.

export DISABLE_XVFB_DRIVER=1

[Csaba Osztrogonác]

Comment on attachment 242165 [details]
Patch

rs=me

[WebKit Commit Bot]

Comment on attachment 242165 [details]
Patch

Clearing flags on attachment: 242165

Committed r176522: <http://trac.webkit.org/changeset/176522>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.