The iOS WebKit port makes use of the private headers from the CoreText and CoreUI frameworks. Towards building the port using the public SDK, we should forward declare the applicable SPI from these frameworks.
Created attachment 241642 [details] Patch
Created attachment 241733 [details] Patch
Attachment 241733 [details] did not pass style-queue: ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:38: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:39: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:40: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:41: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 4 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 241733 [details] Patch r=me
(In reply to comment #3) > Attachment 241733 [details] did not pass style-queue: > > > ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:38: enum members > should use InterCaps with an initial capital letter. > [readability/enum_casing] [4] > ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:39: enum members > should use InterCaps with an initial capital letter. > [readability/enum_casing] [4] > ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:40: enum members > should use InterCaps with an initial capital letter. > [readability/enum_casing] [4] > ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:41: enum members > should use InterCaps with an initial capital letter. > [readability/enum_casing] [4] > Total errors found: 4 in 9 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. I wonder if it would be worth disabling this check for *SPI.h headers? Seems to be a common theme that non-WebKit teams at Apple format their constants this way.
(In reply to comment #5) > [...] > > ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:41: enum members > > should use InterCaps with an initial capital letter. > > [readability/enum_casing] [4] > > Total errors found: 4 in 9 files > > > > > > If any of these errors are false positives, please file a bug against > > check-webkit-style. > > I wonder if it would be worth disabling this check for *SPI.h headers? We could disable such warnings for files whose name ends the suffix SPI.h and/or are in- or in a sub directory of- directory Source/WebCore/platform/spi. Such a change would be beneficial if we anticipate adding such enums regularly.
Comment on attachment 241733 [details] Patch Clearing flags on attachment: 241733 Committed r176229: <http://trac.webkit.org/changeset/176229>
All reviewed patches have been landed. Closing bug.