Bug 138802 - [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt SPI are not available in public SDK
Summary: [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt SPI a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad iOS 8.1
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on: 138760
Blocks: 136487
  Show dependency tree / graph
 
Reported: 2014-11-17 12:06 PST by Daniel Bates
Modified: 2014-11-18 12:40 PST (History)
2 users (show)

See Also:

Attachments
Patch (33.44 KB, patch)
2014-11-17 12:14 PST, Daniel Bates 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-11-17 12:06:22 PST 
The iOS WebKit port makes use of the private headers from the libdispatch, dyld, IOKit, mach, Foundation and MobileGestalt frameworks. Towards building the port using the public SDK, we should forward declare the applicable SPI from these frameworks.
Comment 1 Daniel Bates 2014-11-17 12:14:19 PST 
Created attachment 241730 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2014-11-17 13:42:57 PST 
Comment on attachment 241730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241730&action=review

r=me

> Source/WebCore/ChangeLog:10
> +        that forward declares applicable libdispatch, dyld, IOKit, mach, Foundation, MobileGestalt SPI

Nit:  I think "forward declare" should be singular here.
Comment 3 Daniel Bates 2014-11-17 13:54:52 PST 
(In reply to comment #2)
> > Source/WebCore/ChangeLog:10
> > +        that forward declares applicable libdispatch, dyld, IOKit, mach, Foundation, MobileGestalt SPI
> 
> Nit:  I think "forward declare" should be singular here.

Will fix before landing.
Comment 4 Daniel Bates 2014-11-17 13:58:58 PST 
Committed r176232: <http://trac.webkit.org/changeset/176232>
Comment 5 Daniel Bates 2014-11-17 14:36:20 PST 
Reverted r176232 for reason:

Broke the Mac build. Will investigate offline.

Committed r176234: <http://trac.webkit.org/changeset/176234>
Comment 6 Daniel Bates 2014-11-18 10:05:52 PST 
Committed r176265: <http://trac.webkit.org/changeset/176265>