Bug 138646 - Move WebCore/loader to std::unique_ptr
Summary: Move WebCore/loader to std::unique_ptr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
: 138645 (view as bug list)
Depends on:
Blocks: 128007
  Show dependency treegraph
 
Reported: 2014-11-11 18:01 PST by Gyuyoung Kim
Modified: 2014-11-23 18:25 PST (History)
5 users (show)

See Also:


Attachments
Patch (21.49 KB, patch)
2014-11-11 18:02 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (20.80 KB, patch)
2014-11-11 23:06 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (20.76 KB, patch)
2014-11-12 16:56 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch for landing (20.86 KB, patch)
2014-11-12 18:03 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion (493.70 KB, application/zip)
2014-11-13 17:52 PST, WebKit Commit Bot
no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (606.39 KB, application/zip)
2014-11-13 19:24 PST, Build Bot
no flags Details
Patch for mac ews (20.86 KB, patch)
2014-11-13 20:07 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (1.03 MB, application/zip)
2014-11-13 21:18 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (664.10 KB, application/zip)
2014-11-13 21:37 PST, Build Bot
no flags Details
Patch for landing (17.11 KB, patch)
2014-11-16 21:15 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-11-11 18:01:12 PST
Clean up OwnPtr in WebCore/loader.
Comment 1 Gyuyoung Kim 2014-11-11 18:02:24 PST
Created attachment 241403 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-11-11 19:11:39 PST
*** Bug 138645 has been marked as a duplicate of this bug. ***
Comment 3 Gyuyoung Kim 2014-11-11 23:06:01 PST
Created attachment 241414 [details]
Patch
Comment 4 Gyuyoung Kim 2014-11-12 16:56:33 PST
Created attachment 241453 [details]
Patch
Comment 5 Chris Dumez 2014-11-12 17:26:44 PST
Comment on attachment 241453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241453&action=review

r=me with nits.

> Source/WebCore/ChangeLog:12
> +        No new tests, no behaviro changes.

"behavior"

> Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1362
> +    std::unique_ptr<ApplicationCacheGroup> groupCopy(std::make_unique<ApplicationCacheGroup>(cache->group()->manifestURL(), true));

Don't we usually use "auto groupCopy = make_unique<>(...);" in such cases?
Comment 6 Gyuyoung Kim 2014-11-12 18:03:23 PST
Created attachment 241459 [details]
Patch for landing
Comment 7 Gyuyoung Kim 2014-11-12 18:04:25 PST
(In reply to comment #5)
> Comment on attachment 241453 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241453&action=review
> 
> r=me with nits.
> 
> > Source/WebCore/ChangeLog:12
> > +        No new tests, no behaviro changes.
> 
> "behavior"

Oops, fixed.

> > Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1362
> > +    std::unique_ptr<ApplicationCacheGroup> groupCopy(std::make_unique<ApplicationCacheGroup>(cache->group()->manifestURL(), true));
> 
> Don't we usually use "auto groupCopy = make_unique<>(...);" in such cases?

Why not ? It looks like this style is more clear. Fixed.
Comment 8 WebKit Commit Bot 2014-11-13 17:52:07 PST
Comment on attachment 241459 [details]
Patch for landing

Rejecting attachment 241459 [details] from commit-queue.

Number of test failures exceeded the failure limit.
Full output: http://webkit-queues.appspot.com/results/6591204879761408
Comment 9 WebKit Commit Bot 2014-11-13 17:52:11 PST
Created attachment 241523 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 Build Bot 2014-11-13 19:24:00 PST
Comment on attachment 241459 [details]
Patch for landing

Attachment 241459 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5228930374041600

Number of test failures exceeded the failure limit.
Comment 11 Build Bot 2014-11-13 19:24:04 PST
Created attachment 241528 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 12 Gyuyoung Kim 2014-11-13 20:07:00 PST
Created attachment 241538 [details]
Patch for mac ews
Comment 13 Build Bot 2014-11-13 21:18:11 PST
Comment on attachment 241538 [details]
Patch for mac ews

Attachment 241538 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6120512971341824

New failing tests:
http/tests/appcache/document-write-html-element.html
http/tests/security/beforeload-iframe-client-redirect.html
http/tests/appcache/cyrillic-uri.html
http/tests/appcache/online-whitelist.html
http/tests/cache/cache-redirections.html
http/tests/appcache/history-test.html
http/tests/appcache/crash-when-navigating-away-then-back.html
http/tests/appcache/navigating-away-while-cache-attempt-in-progress.html
http/tests/appcache/max-size.html
http/tests/appcache/origin-quota.html
http/tests/appcache/top-frame-1.html
http/tests/appcache/whitelist-wildcard.html
http/tests/appcache/disabled.html
http/tests/appcache/main-resource-fallback-for-network-error-crash.html
http/tests/appcache/reload.html
http/tests/appcache/foreign-iframe-main.html
http/tests/appcache/main-resource-redirect.html
http/tests/appcache/local-content.html
http/tests/appcache/top-frame-3.html
http/tests/appcache/resource-redirect-2.html
http/tests/appcache/wrong-signature-2.html
http/tests/appcache/manifest-parsing.html
http/tests/appcache/origin-quota-continued-download-multiple-manifests.html
http/tests/appcache/origins-with-appcache.html
http/tests/appcache/update-cache.html
http/tests/appcache/offline-access.html
http/tests/security/cross-origin-appcache.html
http/tests/appcache/fallback.html
Comment 14 Build Bot 2014-11-13 21:18:15 PST
Created attachment 241551 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 15 Build Bot 2014-11-13 21:36:59 PST
Comment on attachment 241538 [details]
Patch for mac ews

Attachment 241538 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4595611676442624

Number of test failures exceeded the failure limit.
Comment 16 Build Bot 2014-11-13 21:37:02 PST
Created attachment 241553 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 17 Gyuyoung Kim 2014-11-16 21:15:46 PST
Created attachment 241692 [details]
Patch for landing
Comment 18 WebKit Commit Bot 2014-11-16 22:46:24 PST
Comment on attachment 241692 [details]
Patch for landing

Clearing flags on attachment: 241692

Committed r176172: <http://trac.webkit.org/changeset/176172>
Comment 19 WebKit Commit Bot 2014-11-16 22:46:30 PST
All reviewed patches have been landed.  Closing bug.