Bug 138411 – [GTK] Expose user script messages to GObject DOM bindings

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Carlos Garcia Campos]

ssia

[Carlos Garcia Campos]

Created attachment 241009 [details]
Patch

The "raw" API is not very convenient to use, we should add custom API to make it easier to use.

[Philippe Normand]

Comment on attachment 241009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241009&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1586
> +    return scalar(grep {$_ eq $domClassName} qw(WebKitDOMDOMWindow WebKitDOMUserMessageHandlersNamespace));

Kind of sad to hardcode this here :( Is this the only way?

[Carlos Garcia Campos]

(In reply to comment #2)
> Comment on attachment 241009 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241009&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1586
> > +    return scalar(grep {$_ eq $domClassName} qw(WebKitDOMDOMWindow WebKitDOMUserMessageHandlersNamespace));
> 
> Kind of sad to hardcode this here :( Is this the only way?

Not easily. When generating code, we know which symbols are not stable (the ones not in the stable symbols list), but custom symbols are not generated but manually implemented. The code generator knows which symbols require a custom implementation, but it doesn't know which custom symbols are actually implemented manually (most of them are simply not implemented).

[Philippe Normand]

Comment on attachment 241009 [details]
Patch

Ok then.

[Carlos Garcia Campos]

Committed r176018: <http://trac.webkit.org/changeset/176018>