Bug 125775 – [GTK] Implement sizes attribute for link tag

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[William Jon McCann]

Bug #37674 implemented sizes attribute support for the link tag, but only for javascript:
+#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
+        attribute [Custom] DOMSettableTokenList sizes;
+#endif

This is really useful because it is pretty common these days to have something like this:
  <link rel="apple-touch-icon-precomposed" href="images/icons/54.png">
  <link rel="apple-touch-icon-precomposed" sizes="72x72"
href="images/icons/72.png">
  <link rel="apple-touch-icon-precomposed" sizes="114x114"
href="images/icons/114.png">
  <link rel="apple-touch-icon-precomposed" sizes="144x144"
href="images/icons/144.png">

So, it would be really useful to have this available from C as well.

[Carlos Garcia Campos]

Created attachment 241014 [details]
Patch

[Carlos Garcia Campos]

This depends on bug #138411, that added the support for custom unstable API.

[Carlos Garcia Campos]

Created attachment 241421 [details]
Rebased patch

It should apply now

[Martin Robinson]

Comment on attachment 241421 [details]
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241421&action=review

> Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp:-43
> -JSValue JSHTMLLinkElement::sizes(ExecState* exec) const
> -{
> -    return toJS(exec, globalObject(), impl().sizes());
> -}
> -

Why are you removing the custom getter?

[Carlos Garcia Campos]

(In reply to comment #4)
> Comment on attachment 241421 [details]
> Rebased patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241421&action=review
> 
> > Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp:-43
> > -JSValue JSHTMLLinkElement::sizes(ExecState* exec) const
> > -{
> > -    return toJS(exec, globalObject(), impl().sizes());
> > -}
> > -
> 
> Why are you removing the custom getter?

Because it's not needed. See https://bugs.webkit.org/show_bug.cgi?id=37674#c30

[Carlos Garcia Campos]

(In reply to comment #5)
> (In reply to comment #4)
> > Comment on attachment 241421 [details]
> > Rebased patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=241421&action=review
> > 
> > > Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp:-43
> > > -JSValue JSHTMLLinkElement::sizes(ExecState* exec) const
> > > -{
> > > -    return toJS(exec, globalObject(), impl().sizes());
> > > -}
> > > -
> > 
> > Why are you removing the custom getter?
> 
> Because it's not needed. See
> https://bugs.webkit.org/show_bug.cgi?id=37674#c30

Note that I also changed the idl, so that the getter is auto-generated, so it's not that I've removed it, but that now it's auto-generated.

[Martin Robinson]

Comment on attachment 241421 [details]
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241421&action=review

>>>> Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp:-43
>>>> -
>>> 
>>> Why are you removing the custom getter?
>> 
>> Because it's not needed. See https://bugs.webkit.org/show_bug.cgi?id=37674#c30
> 
> Note that I also changed the idl, so that the getter is auto-generated, so it's not that I've removed it, but that now it's auto-generated.

Thanks for the information. Do you mind leaving a short note about this in the ChangeLog?

[Carlos Garcia Campos]

(In reply to comment #7)
> Comment on attachment 241421 [details]
> Rebased patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241421&action=review
> 
> >>>> Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp:-43
> >>>> -
> >>> 
> >>> Why are you removing the custom getter?
> >> 
> >> Because it's not needed. See https://bugs.webkit.org/show_bug.cgi?id=37674#c30
> > 
> > Note that I also changed the idl, so that the getter is auto-generated, so it's not that I've removed it, but that now it's auto-generated.
> 
> Thanks for the information. Do you mind leaving a short note about this in
> the ChangeLog?

Sure, thanks!

[Carlos Garcia Campos]

Committed r177143: <http://trac.webkit.org/changeset/177143>