Bug 138363 – Web Inspector: When pausing on exception from console we should show the source and call frames

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Should show source code and call frames for exceptions triggered by console/eval evaluations.

* STEPS TO REPRODUCE
1. Inspect any page.
2. Enable Pause on all exceptions
3. js> setTimeout(function(){[].x.x})
4. When paused, hover over any JavaScript, e.g. "document" in the index.html
  => Exception, no Call Frames, no Source with the exception

* NOTES
Normally we disallow showing __WebInspectorConsole__ sources, but I think we should show it here.

[Radar WebKit Bug Importer]

<rdar://problem/18869487>

[Joseph Pecoraro]

Maybe we should do this if there is a __WebInspectorConsole__ in the call frames, but not if there are __WebInspectorInjectedScript__, which should be internal only.

In fact, I think we had a workaround in the frontend to auto-continue in those cases, which we should add back.

See related:
<https://webkit.org/b/138341> Web Inspector: Inspector pauses 3 times when evaluating window.decodeURI('%%%')

[Timothy Hatcher]

The idea of not pausing for exceptions from the console is to make the REPL be very friendly to errors. You should see the exception Error logged as the result. For timeouts, that is tricky and likely an edge case.

I don't want to make the common case of getting an immediate exception cause the debugger to pause in a __WebInspectorConsole__ source resource.

[Joseph Pecoraro]

Tim, I think you effectively fixed this by showing the Console Evaluation script.

[Timothy Hatcher]

Yep.