Bug 137974 - [GTK] Prefer GTK implementation over native Windows
Summary: [GTK] Prefer GTK implementation over native Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 137488
  Show dependency treegraph
Reported: 2014-10-22 11:36 PDT by Milan Crha
Modified: 2016-01-06 20:22 PST (History)
19 users (show)

See Also:

proposed wk patch (33.25 KB, patch)
2014-10-22 11:38 PDT, Milan Crha
mcatanzaro: review-
mcatanzaro: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Crha 2014-10-22 11:36:07 PDT
I'm building WebKit under mingw/msys and when the GTK platform is enabled, together with the WIN platform, then only one of them can be used. Better to prefer the GTK implementation of the "same" functions, to reuse what GTK has. Currently the code expect that either WIN or GTK platform is enabled, which might not be always true.
Comment 1 Milan Crha 2014-10-22 11:38:28 PDT
Created attachment 240284 [details]
proposed wk patch
Comment 2 Michael Catanzaro 2016-01-06 20:21:55 PST
Comment on attachment 240284 [details]
proposed wk patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240284&action=review

Milan, sorry for the late review. I'm going to r- this simply because the GTK port does not have any support for Windows anymore. If that situation ever changes (if you or someone else ever gets it working), then of course it would make sense to reconsider this patch.

> Source/WTF/wtf/Compiler.h:97
> +#define WTF_COMPILER_GCC 1

I don't think this is right; a quick Google search tells me that MinGW supports Clang. Even though clang pretends to be GCC, we don't want COMPILER(GCC) to return true unless the compiler really is GCC.