Bug 137962 - [Win] DumpRenderTree is improperly turning setShouldPaintNativeControls off
Summary: [Win] DumpRenderTree is improperly turning setShouldPaintNativeControls off
Status: RESOLVED DUPLICATE of bug 25592
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-22 09:15 PDT by Brent Fulgham
Modified: 2015-01-24 18:59 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-10-22 09:15:12 PDT
After turning off our use of the deprecated SafariTheme painting routines, it is now revealed that the standard rendering path for <select> on Windows is broken. This has been masked for a long time by the custom drawing routines in SafariTheme that are only used during layout tests.
Comment 1 Brent Fulgham 2014-10-22 10:36:24 PDT
The following failures are due to this rendering bug:

editing/pasteboard/4641033.html
editing/pasteboard/4944770-1.html
editing/pasteboard/4944770-2.html
editing/selection/caret-before-select.html
editing/selection/select-box.html
editing/selection/select-element-paragraph-boundary.html
fast/block/float/float-avoidance.html
fast/block/margin-collapse/103.html
fast/forms/001.html
fast/forms/003.html
fast/forms/004.html
fast/forms/HTMLOptionElement_label01.html
fast/forms/HTMLOptionElement_label02.html
fast/forms/HTMLOptionElement_label03.html
fast/forms/HTMLOptionElement_label04.html
fast/forms/basic-selects.html
fast/forms/control-clip-overflow.html
fast/forms/control-restrict-line-height.html
fast/forms/menulist-deselect-update.html
fast/forms/menulist-narrow-width.html
fast/forms/menulist-no-overflow.html
fast/forms/select-align.html
fast/forms/select-baseline.html
fast/forms/select-change-listbox-to-popup.html
fast/forms/select-dirty-parent-pref-widths.html
fast/forms/select-selected.html
fast/forms/select-style.html
fast/forms/select/optgroup-rendering.html
fast/invalid/014.html
fast/parser/document-write-option.html
fast/replaced/replaced-breaking-mixture.html
fast/text/international/pop-up-button-text-alignment-and-direction.html
tables/mozilla/bugs/bug18359.html
tables/mozilla/bugs/bug29326.html
tables/mozilla/bugs/bug33855.html
tables/mozilla/bugs/bug4382.html
tables/mozilla/bugs/bug96334.html
tables/mozilla/core/margins.html
tables/mozilla/dom/tableDom.html
Comment 2 Brent Fulgham 2014-10-22 10:45:13 PDT
Bad tests marked as failing in <http://trac.webkit.org/changeset/175054>.
Comment 3 Radar WebKit Bug Importer 2014-10-28 23:52:18 PDT
<rdar://problem/18807814>
Comment 4 Radar WebKit Bug Importer 2014-10-28 23:52:19 PDT
<rdar://problem/18807815>
Comment 5 Brent Fulgham 2015-01-24 11:07:56 PST
As of January, 2015 these have started working again. These problems may have been fixed by some of the rendering updates done in the past few weeks.
Comment 6 Brent Fulgham 2015-01-24 13:47:44 PST
(In reply to comment #5)
> As of January, 2015 these have started working again. These problems may
> have been fixed by some of the rendering updates done in the past few weeks.

Well that was totally wrong! It turns out that this is a rendering difference between WinLauncher and DumpRenderTree. The issue is that DRT is improperly calling setShouldPaintNativeControls(FALSE) during the run, which is wreaking havoc on the test runs.
Comment 7 Brent Fulgham 2015-01-24 18:59:32 PST

*** This bug has been marked as a duplicate of bug 25592 ***