In bug137606 I suggested to disable using response files if we use VERBOSE build to be able copy/paste the command and be able run manually. Unfortunately the linking fails in this case with "Argument list too long". The another problem is that ninja automatically removes response files. But we can use "-d keeprsp" not to remove rsp files if we have ninja 1.5.1 or newer.
Response file are necessary because CMake + Ninja does not know how to add files to ar archives in chunks. Instead it will try to add them using one command invocation.
Created attachment 240601 [details] Patch "-d keeprsp" is available since ninja version 1.4.0, so created the feature according to this.
Created attachment 240602 [details] Patch
Created attachment 240603 [details] Patch
Ping?
Comment on attachment 240603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240603&action=review The idea is good, but I suggest some minor style changes. > Tools/Scripts/webkitdirs.pm:170 > + my $ninjaVersion = `ninja --version`; > + $ninjaVersion =~ s/\R//g; I think chomp is better choice here: chomp(my $ninjaVersion = `ninja --version`); > Tools/Scripts/webkitdirs.pm:1841 > + > + if (version->parse(determineNinjaVersion()) >= version->parse("1.4.0")) { > + push @args, "-d keeprsp"; > + } We can do it in one line: push @args, "-d keeprsp" if (version->parse(determineNinjaVersion()) >= version->parse("1.4.0"));
Created attachment 240834 [details] Patch for landing
Comment on attachment 240834 [details] Patch for landing Clearing flags on attachment: 240834 Committed r175469: <http://trac.webkit.org/changeset/175469>
All reviewed patches have been landed. Closing bug.