Bug 137606 – [EFL][GTK] Make it possible to get verbose output with ninja

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Éva Balázsfalvi]

Make it possible to get verbose output with ninja on gtk and efl port as well.

[Éva Balázsfalvi]

Created attachment 239626 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 239626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239626&action=review

I like the idea, but I think we need some minor fixes.
 
When we use verbose build, we usually do it to be able copy/paste
a command and then run it manually, maybe after some manual editing
or simple check all the command line arguments.

In this case we should disable forcing response files too, see:
http://trac.webkit.org/browser/trunk/Source/cmake/OptionsCommon.cmake#L68

> Tools/Scripts/webkitdirs.pm:1832
> +    push @args, "-v" if $ENV{VERBOSE} or $ENV{V};

I think VERBOSE environment variable is enough, we don't need
two. The makefilegenerator of CMake use VERBOSE also, so it is 
a good choice. V is an autotoolsism, we can avoid using it here.

[Éva Balázsfalvi]

(In reply to comment #2)
> (From update of attachment 239626 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239626&action=review
> 
> I like the idea, but I think we need some minor fixes.
> 
> When we use verbose build, we usually do it to be able copy/paste
> a command and then run it manually, maybe after some manual editing
> or simple check all the command line arguments.
> 
> In this case we should disable forcing response files too, see:
> http://trac.webkit.org/browser/trunk/Source/cmake/OptionsCommon.cmake#L68
> 
> > Tools/Scripts/webkitdirs.pm:1832
> > +    push @args, "-v" if $ENV{VERBOSE} or $ENV{V};
> 
> I think VERBOSE environment variable is enough, we don't need
> two. The makefilegenerator of CMake use VERBOSE also, so it is 
> a good choice. V is an autotoolsism, we can avoid using it here.

I'll remove the V environment variable, thanks for pointing out.

However, I tried an EFL build with disabling response files as requested, but even with verbose enabled, the linking failed with "Argument list too long".

Shortened version of the last few rows of received console output:

[5/96] cd /home/eva/webkit/WebKit/WebKitBuild/Release/Tools/TestWebKitAPI && ............ /home/eva/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/include soup
FAILED: : && /usr/bin/cmake -E remove lib/libwebcore_efl.a && /usr/bin/ar ............  && /usr/bin/ranlib lib/libwebcore_efl.a && :
Argument list too long
ninja: build stopped: subcommand failed.

[Éva Balázsfalvi]

Created attachment 239801 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 239801 [details]
Patch

Clearing flags on attachment: 239801

Committed r174683: <http://trac.webkit.org/changeset/174683>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Martin Robinson]

Comment on attachment 239801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239801&action=review

> Tools/Scripts/webkitdirs.pm:1832
> +    push @args, "-v" if $ENV{VERBOSE};

It doesn't look like this will work for make-based builds...

[Csaba Osztrogonác]

(In reply to comment #7)
> (From update of attachment 239801 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239801&action=review
> 
> > Tools/Scripts/webkitdirs.pm:1832
> > +    push @args, "-v" if $ENV{VERBOSE};
> 
> It doesn't look like this will work for make-based builds...

Oops, make -v is really fast, but doesn't do any build task. :)
Fix is in bug137703. Sorry for the trouble.