Bug 137739 – [GTK]FindHarfBuzz.cmake dose not handle harfbuzz-icu correctly

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[宋文武]

Suppose I have harfbuzz and harfbuzz-icu install to two different directories,
then paths to hb.h and hb-icu.h should both included in HARFBUZZ_INCLUDE_DIRS.
And the ``list APPEND`` method does not really work.

Here is a patch I used to package it for NixOS.

Version: webkitgtk-2.6.1

[宋文武]

Created attachment 239870 [details]
cmake: finding harfbuzz-icu

[Alberto Garcia]

Why don't you (In reply to comment #0)
> Suppose I have harfbuzz and harfbuzz-icu install to two different
> directories,

> then paths to hb.h and hb-icu.h should both included in
> HARFBUZZ_INCLUDE_DIRS.

I'm not a cmake expert, but why don't you look for hb.h in the new patch then?

In the HarfBuff >= 0.9.18 branch of the if I only see hb-icu.h.

[宋文武]

(In reply to comment #2)
> Why don't you (In reply to comment #0)
> > Suppose I have harfbuzz and harfbuzz-icu install to two different
> > directories,
> 
> > then paths to hb.h and hb-icu.h should both included in
> > HARFBUZZ_INCLUDE_DIRS.
> 
> I'm not a cmake expert, but why don't you look for hb.h in the new patch
> then?
Obvious, I'm not a cmake expert too :)
Ah yes, It's good to add a find_path for hb.h too.
Even pkg_check_modules(PC_HARFBUZZ harfbuzz>=0.9.7) should given a corret PC_HARFBUZZ_INCLUDE_DIRS (having hb.h).

> In the HarfBuff >= 0.9.18 branch of the if I only see hb-icu.h.

fixed by https://bugs.webkit.org/show_bug.cgi?id=220082