Bug 220082 - [CMake] Fix seperated include dir of harfbuzz and harfbuzz-icu
Summary: [CMake] Fix seperated include dir of harfbuzz and harfbuzz-icu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-22 02:17 PST by monson
Modified: 2020-12-23 08:53 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2020-12-22 02:28 PST, monson 		no flags Details | Formatted Diff | Diff
Patch (2.21 KB, patch)
2020-12-23 04:12 PST, monson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description monson 2020-12-22 02:17:27 PST 
[CMake] Fix seperated include dir of harfbuzz and harfbuzz-icu
Comment 1 monson 2020-12-22 02:28:08 PST 
Created attachment 416657 [details]
Patch

In some distros (NixOS) harfbuzz and harfbuzz-icu may have different include dir.
Comment 2 Radar WebKit Bug Importer 2020-12-22 11:18:19 PST 
<rdar://problem/72593922>
Comment 3 Fujii Hironori 2020-12-22 19:53:48 PST 
Comment on attachment 416657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416657&action=review

LGTM.

> ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Could you add your comment#2 in the ChangeLog?
Comment 4 monson 2020-12-23 04:12:39 PST 
Created attachment 416708 [details]
Patch
Comment 5 EWS 2020-12-23 08:53:22 PST 
Committed r271069: <https://trac.webkit.org/changeset/271069>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416708 [details].