Bug 137710 - [Win] Enable Encrypted Media Support
Summary: [Win] Enable Encrypted Media Support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 134418 137409
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-14 12:23 PDT by Brent Fulgham
Modified: 2014-10-14 13:11 PDT (History)
9 users (show)

See Also:


Attachments
Patch (9.41 KB, patch)
2014-10-14 12:30 PDT, Brent Fulgham
jer.noble: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-10-14 12:23:03 PDT
This patch makes the following changes:
1. Activate the ENCRYPTED_MEDIA_V2 support on Windows.
2. Handle possible calls to PlatformCALayerWinInternal::displayCallback on background queue.

We do not support performing display operations off the main thread, but some callbacks are generated in background queues. We need to re-dispatch such calls on the main thread to avoid violating this fundamental rule for our layout design.
Comment 1 Radar WebKit Bug Importer 2014-10-14 12:23:23 PDT
<rdar://problem/18652699>
Comment 2 Brent Fulgham 2014-10-14 12:30:44 PDT
Created attachment 239817 [details]
Patch
Comment 3 Jer Noble 2014-10-14 12:38:02 PDT
Comment on attachment 239817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239817&action=review

r=me, with nit:

> Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:72
> +struct displayOnMainThreadContext {

Nit: displayOnMainThreadContext -> DisplayOnMainThreadContext
Comment 4 Brent Fulgham 2014-10-14 12:51:39 PDT
Comment on attachment 239817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239817&action=review

>> Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:72
>> +struct displayOnMainThreadContext {
> 
> Nit: displayOnMainThreadContext -> DisplayOnMainThreadContext

It shall be done!
Comment 5 Brent Fulgham 2014-10-14 13:11:29 PDT
Committed r174698: <http://trac.webkit.org/changeset/174698>