RESOLVED FIXED137409
[Win] Extend AVFoundationCF Media Implementation 
https://bugs.webkit.org/show_bug.cgi?id=137409
Summary [Win] Extend AVFoundationCF Media Implementation
Brent Fulgham
Reported 2014-10-03 15:06:25 PDT
Correct few errors in the existing AVFoundationCF implementation, and add initial support for encrypted streams. This code is not being built as part of the standard build yet, and is not yet being tested. These changes are only accessible if you manually modify the ENCRYPTED_MEDIA_V2 is enabled.
Attachments
Patch (21.62 KB, patch)
2014-10-03 15:17 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (22.03 KB, patch)
2014-10-03 15:22 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-10-03 15:17:59 PDT
Created attachment 239241 [details] Patch
Brent Fulgham
Comment 2 2014-10-03 15:22:12 PDT
Created attachment 239242 [details] Patch
Eric Carlson
Comment 3 2014-10-04 05:34:26 PDT
Comment on attachment 239242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239242&action=review > Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:929 > + if (!keySystem.isEmpty()) { Nit: this could become an early return. > Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:2033 > + if (requestsIterator == m_keyURIToRequestMap.end()) { Nit: this could also become an early return.
Brent Fulgham
Comment 4 2014-10-06 10:49:28 PDT
Committed r174346: <http://trac.webkit.org/changeset/174346>
Brent Fulgham
Comment 5 2014-10-06 11:02:20 PDT
Build fix for machines without ENCYPTED_MEDIA_V2 enabled checked in under r174350: <http://trac.webkit.org/changeset/174350>
Note You need to log in before you can comment on or make changes to this bug.