Bug 137560 - [GTK][JSC] Disassembly not available on ARM64
Summary: [GTK][JSC] Disassembly not available on ARM64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-09 08:39 PDT by Akos Kiss
Modified: 2014-10-09 11:10 PDT (History)
7 users (show)

See Also:


Attachments
Proposed patch. (1.11 KB, patch)
2014-10-09 08:46 PDT, Akos Kiss
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Akos Kiss 2014-10-09 08:39:29 PDT
When running jsc with "--showDisassembly=true --showDFGDisassembly=true" on GTK/ARM64, the output contains only "disassembly not available for range ..." lines in place of the disassembled instructions. The same problem has already been solved on EFL/ARM64.
Comment 1 Akos Kiss 2014-10-09 08:46:22 PDT
Created attachment 239540 [details]
Proposed patch.

Actually, the patch that got landed for https://bugs.webkit.org/show_bug.cgi?id=136089 has already put everything in place for any CMake-based builds. Enabling the disassembler for EFL only was simply a conservative step, since the GTK/ARM64 build had not been tested at that time. Now that it works, the disassembler can be enabled as well.
Comment 2 Michael Saboff 2014-10-09 10:35:47 PDT
Comment on attachment 239540 [details]
Proposed patch.

r=me
Comment 3 WebKit Commit Bot 2014-10-09 11:10:36 PDT
Comment on attachment 239540 [details]
Proposed patch.

Clearing flags on attachment: 239540

Committed r174511: <http://trac.webkit.org/changeset/174511>
Comment 4 WebKit Commit Bot 2014-10-09 11:10:41 PDT
All reviewed patches have been landed.  Closing bug.