Bug 137243 – Generalize is<>() / downcast<>() support to all types

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Generalize is<>() / downcast<>() support to all types, not just Nodes.

[Chris Dumez]

Created attachment 238907 [details]
Patch

[WebKit Commit Bot]

Attachment 238907 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLElement.h:159:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/mathml/MathMLElement.h:86:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 67 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 238910 [details]
Patch

[WebKit Commit Bot]

Attachment 238910 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLElement.h:159:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/mathml/MathMLElement.h:86:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 69 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 238911 [details]
Patch

[WebKit Commit Bot]

Attachment 238911 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLElement.h:159:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/mathml/MathMLElement.h:86:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 69 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 238923 [details]
Patch

[WebKit Commit Bot]

Attachment 238923 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLElement.h:159:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/mathml/MathMLElement.h:86:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 69 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Benjamin Poulain]

Comment on attachment 238923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238923&action=review

> Source/WebCore/bindings/js/JSEventListener.cpp:136
> -        if (scriptExecutionContext->isWorkerGlobalScope()) {
> +        if (is<WorkerGlobalScope>(scriptExecutionContext)) {
>              bool terminatorCausedException = (exec->hadException() && isTerminatedExecutionException(exec->exception()));
>              if (terminatorCausedException || (vm.watchdog && vm.watchdog->didFire()))

I wonder why those conditions are in that order, looks a bit backward to me.

> Source/WebCore/dom/Element.h:789
> +namespace WTF {
> +template <>
> +struct TypeCastTraits<const WebCore::Element, const WebCore::Node> {
> +    static bool isOfType(const WebCore::Node& node) { return node.isElementNode(); }
> +};
> +}

Would SPECIALIZE_TYPE_TRAITS_BEGIN work here?

> Source/WebCore/dom/ScriptExecutionContext.h:-240
> -#define SCRIPT_EXECUTION_CONTEXT_TYPE_CASTS(ToValueTypeName) \
> -    template<typename T> inline ToValueTypeName* to##ToValueTypeName(const RefPtr<T>& context) { return to##ToValueTypeName(context.get()); } \
> -    TYPE_CASTS_BASE(ToValueTypeName, ScriptExecutionContext, context, context->is##ToValueTypeName(), context.is##ToValueTypeName())
> -

Die preprocessor, die!

[Chris Dumez]

Comment on attachment 238923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238923&action=review

>> Source/WebCore/dom/Element.h:789
>> +}
> 
> Would SPECIALIZE_TYPE_TRAITS_BEGIN work here?

https://bugs.webkit.org/show_bug.cgi?id=137241 is taking care of this. It is in the commit queue. I'll rebase this patch as soon as the other one lands.

[Chris Dumez]

Created attachment 238950 [details]
Patch

[WebKit Commit Bot]

Attachment 238950 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLElement.h:159:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/mathml/MathMLElement.h:86:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 69 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 238955 [details]
Patch

[WebKit Commit Bot]

Attachment 238955 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLElement.h:159:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/mathml/MathMLElement.h:86:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 70 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 238955 [details]
Patch

Clearing flags on attachment: 238955

Committed r174125: <http://trac.webkit.org/changeset/174125>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.