Bug 137241 - Use is<>() / downcast<>() for Element
Summary: Use is<>() / downcast<>() for Element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137056
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-29 18:08 PDT by Chris Dumez
Modified: 2014-09-30 12:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (207.63 KB, patch)
2014-09-29 18:28 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (208.08 KB, patch)
2014-09-29 19:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (208.67 KB, patch)
2014-09-29 20:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-09-29 18:08:49 PDT 
Use is<>() / downcast<>() for Element instead of isElementNode() / toElement().
Comment 1 Chris Dumez 2014-09-29 18:28:25 PDT 
Created attachment 238900 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-29 18:31:05 PDT 
Attachment 238900 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLFormControlElement.h:195:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:914:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLTextFormControlElement.h:156:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/editing/CompositeEditCommand.cpp:1352:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 4 in 108 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2014-09-29 19:05:56 PDT 
Created attachment 238901 [details]
Patch
Comment 4 WebKit Commit Bot 2014-09-29 19:09:18 PDT 
Attachment 238901 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLFormControlElement.h:195:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:914:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLTextFormControlElement.h:156:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/editing/CompositeEditCommand.cpp:1352:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 4 in 108 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Chris Dumez 2014-09-29 20:22:28 PDT 
Created attachment 238905 [details]
Patch
Comment 6 WebKit Commit Bot 2014-09-29 20:24:20 PDT 
Attachment 238905 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLFormControlElement.h:195:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:914:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLTextFormControlElement.h:156:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/editing/CompositeEditCommand.cpp:1352:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 4 in 108 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Andreas Kling 2014-09-30 12:22:11 PDT 
Comment on attachment 238905 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2014-09-30 12:59:54 PDT 
Comment on attachment 238905 [details]
Patch

Clearing flags on attachment: 238905

Committed r174117: <http://trac.webkit.org/changeset/174117>
Comment 9 WebKit Commit Bot 2014-09-30 12:59:59 PDT 
All reviewed patches have been landed.  Closing bug.